archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 07:14:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8281217: Source file launch with security manager enabled fails

Browse source 
Reviewed-by: sundar
This commit is contained in:
Jonathan Gibbons 2022-02-23 16:49:28 +00:00
parent 35076af13a
commit 99b8ed9dbf
3 changed files with 39 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

58
test/langtools/tools/javac/launcher/SourceLauncherTest.java
View file

@ -213,48 +213,22 @@ public class SourceLauncherTest extends TestRunner {
}
@Test
public void testPermissions(Path base) throws IOException {
// does not work on exploded image, because the default policy file assumes jrt:; skip the test
if (Files.exists(Path.of(System.getProperty("java.home")).resolve("modules"))) {
out.println("JDK using exploded modules; test skipped");
return;
}
Path policyFile = base.resolve("test.policy");
Path sourceFile = base.resolve("TestPermissions.java");
tb.writeFile(policyFile,
"grant codeBase \"jrt:/jdk.compiler\" {\n" +
" permission java.security.AllPermission;\n" +
"};\n" +
"grant codeBase \"" + sourceFile.toUri().toURL() + "\" {\n" +
" permission java.util.PropertyPermission \"user.dir\", \"read\";\n" +
"};\n");
public void testSecurityManager(Path base) throws IOException {
Path sourceFile = base.resolve("HelloWorld.java");
tb.writeJavaFiles(base,
"import java.net.URL;\n" +
"class TestPermissions {\n" +
" public static void main(String... args) {\n" +
" System.out.println(\"user.dir=\" + System.getProperty(\"user.dir\"));\n" +
" try {\n" +
" System.setProperty(\"user.dir\", \"\");\n" +
" System.out.println(\"no exception\");\n" +
" System.exit(1);\n" +
" } catch (SecurityException e) {\n" +
" System.out.println(\"exception: \" + e);\n" +
" }\n" +
" }\n" +
"}");
"class HelloWorld {\n" +
" public static void main(String... args) {\n" +
" System.out.println(\"Hello World!\");\n" +
" }\n" +
"}");
String log = new JavaTask(tb)
.vmOptions("-Djava.security.manager", "-Djava.security.policy=" + policyFile)
.vmOptions("-Djava.security.manager=default")
.className(sourceFile.toString())
.run(Task.Expect.SUCCESS)
.getOutput(Task.OutputKind.STDOUT);
checkEqual("stdout", log.trim(),
"user.dir=" + System.getProperty("user.dir") + "\n" +
"exception: java.security.AccessControlException: " +
"access denied (\"java.util.PropertyPermission\" \"user.dir\" \"write\")");
.run(Task.Expect.FAIL)
.getOutput(Task.OutputKind.STDERR);
checkContains("stderr", log,
"error: cannot use source-code launcher with a security manager enabled");
}
public void testSystemProperty(Path base) throws IOException {
@ -710,6 +684,14 @@ public class SourceLauncherTest extends TestRunner {
}
}
void checkContains(String name, String found, String expect) {
expect = expect.replace("\n", tb.lineSeparator);
out.println(name + ": " + found);
if (!found.contains(expect)) {
error("Expected output not found: " + expect);
}
}
void checkEqual(String name, List<String> found, List<String> expect) {
out.println(name + ": " + found);
tb.checkEqual(expect, found);