archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 17:44:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8228673: Remove develop flag StrictSafepointChecks

Browse source 
Reviewed-by: shade, dholmes
This commit is contained in:
Coleen Phillimore 2019-07-31 06:37:13 -04:00
parent 8996d4782d
commit 9ad5641ce5
4 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/hotspot/share/gc/shared/memAllocator.cpp
View file

@ -172,12 +172,10 @@ void MemAllocator::Allocation::check_for_valid_allocation_state() const {
// This is a VM policy failure, so how do we exhaustively test it? // This is a VM policy failure, so how do we exhaustively test it?
assert(!_thread->has_pending_exception(), assert(!_thread->has_pending_exception(),
"shouldn't be allocating with pending exception"); "shouldn't be allocating with pending exception");
if (StrictSafepointChecks) {
// Allocation of an oop can always invoke a safepoint, // Allocation of an oop can always invoke a safepoint,
// hence, the true argument. // hence, the true argument.
_thread->check_for_valid_safepoint_state(true); _thread->check_for_valid_safepoint_state(true);
} }
}
#endif #endif
void MemAllocator::Allocation::notify_allocation_jvmti_sampler() { void MemAllocator::Allocation::notify_allocation_jvmti_sampler() {

4
src/hotspot/share/runtime/globals.hpp
View file

@ -398,10 +398,6 @@ const size_t minimumSymbolTableSize = 1024;
"Set when executing debug methods in debug.cpp " \ "Set when executing debug methods in debug.cpp " \
"(to prevent triggering assertions)") \ "(to prevent triggering assertions)") \
\ \
notproduct(bool, StrictSafepointChecks, trueInDebug, \
"Enable strict checks that safepoints cannot happen for threads " \
"that use NoSafepointVerifier") \
\
notproduct(bool, VerifyLastFrame, false, \ notproduct(bool, VerifyLastFrame, false, \
"Verify oops on last frame on entry to VM") \ "Verify oops on last frame on entry to VM") \
\ \

2
src/hotspot/share/runtime/mutex.cpp
View file

@ -53,7 +53,7 @@ void Monitor::lock(Thread * self) {
} }
#endif // CHECK_UNHANDLED_OOPS #endif // CHECK_UNHANDLED_OOPS
DEBUG_ONLY(check_prelock_state(self, StrictSafepointChecks)); DEBUG_ONLY(check_prelock_state(self, true));
assert(_owner != self, "invariant"); assert(_owner != self, "invariant");
Monitor* in_flight_monitor = NULL; Monitor* in_flight_monitor = NULL;

2
src/hotspot/share/runtime/synchronizer.cpp
View file

@ -442,7 +442,7 @@ void ObjectSynchronizer::jni_exit(oop obj, Thread* THREAD) {
ObjectLocker::ObjectLocker(Handle obj, Thread* thread, bool doLock) { ObjectLocker::ObjectLocker(Handle obj, Thread* thread, bool doLock) {
_dolock = doLock; _dolock = doLock;
_thread = thread; _thread = thread;
debug_only(if (StrictSafepointChecks) _thread->check_for_valid_safepoint_state(false);) _thread->check_for_valid_safepoint_state(false);
_obj = obj; _obj = obj;
if (_dolock) { if (_dolock) {