archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8210861: Move assert to help diagnose rare RedefineStress crash

Browse source 
Assert that Method being marked on stack hasn't been missed by previous metadata walk

Reviewed-by: lfoltan
This commit is contained in:
Coleen Phillimore 2018-09-18 16:11:36 -04:00
parent d31e1ca5a4
commit a3931a76f6
2 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/hotspot/share/oops/method.cpp
View file

@ -2152,6 +2152,8 @@ void Method::set_on_stack(const bool value) {
if (value && !already_set) { if (value && !already_set) {
MetadataOnStackMark::record(this); MetadataOnStackMark::record(this);
} }
assert(!value || !is_old() || is_obsolete() || is_running_emcp(),
"emcp methods cannot run after emcp bit is cleared");
} }
// Called when the class loader is unloaded to make all methods weak. // Called when the class loader is unloaded to make all methods weak.

1
test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java
View file

@ -32,6 +32,7 @@
* /test/lib * /test/lib
* @run driver jdk.test.lib.FileInstaller . . * @run driver jdk.test.lib.FileInstaller . .
* @run main/othervm/native * @run main/othervm/native
* -Xlog:redefine+class+iklass+purge=trace,redefine+class+iklass+add=trace
* -agentlib:stressRedefine * -agentlib:stressRedefine
* nsk.jvmti.RedefineClasses.StressRedefine * nsk.jvmti.RedefineClasses.StressRedefine
* ./bin * ./bin