archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28

Browse source 
Reviewed-by: iklam, alanb
This commit is contained in:
Jim Laskey 2021-04-05 14:12:26 +00:00
parent 7f9ece23dc
commit a8005efde3
2 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/java.base/share/native/libjimage/imageFile.cpp
View file

@ -211,17 +211,6 @@ ImageFileReaderTable::ImageFileReaderTable() : _count(0), _max(_growth) {
assert(_table != NULL && "allocation failed");
}
ImageFileReaderTable::~ImageFileReaderTable() {
for (u4 i = 0; i < _count; i++) {
ImageFileReader* image = _table[i];
if (image != NULL) {
delete image;
}
}
free(_table);
}
// Add a new image entry to the table.
void ImageFileReaderTable::add(ImageFileReader* image) {
if (_count == _max) {

7
src/java.base/share/native/libjimage/imageFile.hpp
View file

@ -371,7 +371,12 @@ private:
public:
ImageFileReaderTable();
~ImageFileReaderTable();
// ~ImageFileReaderTable()
// Bug 8166727
//
// WARNING: Should never close jimage files.
// Threads may still be running during shutdown.
//
// Return the number of entries.
inline u4 count() { return _count; }