archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

8152176: Big ParGCCardsPerStrideChunk values can cause overflow for CMS GC

Browse source 
Limit the max value of ParGCCardsPerStrideChunk based on card table size and other stride flags

Reviewed-by: jmasa, tbenson
This commit is contained in:
Sangheon Kim 2016-04-01 09:43:13 -07:00
parent c3469071aa
commit a868617af7
4 changed files with 44 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
hotspot/src/share/vm/gc/shared/cardTableModRefBS.hpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2015, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -89,14 +89,6 @@ class CardTableModRefBS: public ModRefBarrierSet {
MemRegion _guard_region;
protected:
// Initialization utilities; covered_words is the size of the covered region
// in, um, words.
inline size_t cards_required(size_t covered_words) {
// Add one for a guard card, used to detect errors.
const size_t words = align_size_up(covered_words, card_size_in_words);
return words / card_size_in_words + 1;
}
inline size_t compute_byte_map_size();
// Finds and return the index of the region, if any, to which the given
@ -172,6 +164,14 @@ public:
bool has_write_ref_pre_barrier() { return false; }
// Initialization utilities; covered_words is the size of the covered region
// in, um, words.
inline size_t cards_required(size_t covered_words) {
// Add one for a guard card, used to detect errors.
const size_t words = align_size_up(covered_words, card_size_in_words);
return words / card_size_in_words + 1;
}
protected:
CardTableModRefBS(MemRegion whole_heap, const BarrierSet::FakeRtti& fake_rtti);