archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 23:04:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

6820066: Check that -XX:ParGCArrayScanChunk has a value larger than zero

Browse source 
Check that -XX:ParGCArrayScanChunk has a value larger than zero.

Reviewed-by: johnc, jmasa, ysr
This commit is contained in:
Jesper Wilhelmsson 2011-03-11 16:35:18 +01:00
parent edb9e105eb
commit aad948f0e8
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hotspot/src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp
View file

@ -411,7 +411,7 @@ oop PSPromotionManager::copy_to_survivor_space(oop o) {
template <class T> void PSPromotionManager::process_array_chunk_work( template <class T> void PSPromotionManager::process_array_chunk_work(
oop obj, oop obj,
int start, int end) { int start, int end) {
assert(start < end, "invariant"); assert(start <= end, "invariant");
T* const base = (T*)objArrayOop(obj)->base(); T* const base = (T*)objArrayOop(obj)->base();
T* p = base + start; T* p = base + start;
T* const chunk_end = base + end; T* const chunk_end = base + end;

6
hotspot/src/share/vm/runtime/arguments.cpp
View file

@ -1668,13 +1668,13 @@ bool Arguments::verify_interval(uintx val, uintx min,
} }
bool Arguments::verify_min_value(intx val, intx min, const char* name) { bool Arguments::verify_min_value(intx val, intx min, const char* name) {
// Returns true if given value is greater than specified min threshold // Returns true if given value is at least specified min threshold
// false, otherwise. // false, otherwise.
if (val >= min ) { if (val >= min ) {
return true; return true;
} }
jio_fprintf(defaultStream::error_stream(), jio_fprintf(defaultStream::error_stream(),
"%s of " INTX_FORMAT " is invalid; must be greater than " INTX_FORMAT "\n", "%s of " INTX_FORMAT " is invalid; must be at least " INTX_FORMAT "\n",
name, val, min); name, val, min);
return false; return false;
} }
@ -1901,6 +1901,8 @@ bool Arguments::check_vm_args_consistency() {
status = false; status = false;
} }
status = status && verify_min_value(ParGCArrayScanChunk, 1, "ParGCArrayScanChunk");
#ifndef SERIALGC #ifndef SERIALGC
if (UseG1GC) { if (UseG1GC) {
status = status && verify_percentage(InitiatingHeapOccupancyPercent, status = status && verify_percentage(InitiatingHeapOccupancyPercent,