archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8058265: No callers of ReferenceProcessor::clear_discovered_references

Browse source 
Removed unused or unneeded code.

Reviewed-by: brutisso, jmasa
This commit is contained in:
Kim Barrett 2015-05-14 15:17:36 -04:00
parent f05640eb98
commit ab4ba3b40f
2 changed files with 1 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

26
hotspot/src/share/vm/gc/shared/referenceProcessor.cpp
View file

@ -189,7 +189,6 @@ ReferenceProcessorStats ReferenceProcessor::process_discovered_references(
AbstractRefProcTaskExecutor* task_executor, AbstractRefProcTaskExecutor* task_executor,
GCTimer* gc_timer, GCTimer* gc_timer,
GCId gc_id) { GCId gc_id) {
NOT_PRODUCT(verify_ok_to_handle_reflists());
assert(!enqueuing_is_done(), "If here enqueuing should not be complete"); assert(!enqueuing_is_done(), "If here enqueuing should not be complete");
// Stop treating discovered references specially. // Stop treating discovered references specially.
@ -329,7 +328,6 @@ bool enqueue_discovered_ref_helper(ReferenceProcessor* ref,
} }
bool ReferenceProcessor::enqueue_discovered_references(AbstractRefProcTaskExecutor* task_executor) { bool ReferenceProcessor::enqueue_discovered_references(AbstractRefProcTaskExecutor* task_executor) {
NOT_PRODUCT(verify_ok_to_handle_reflists());
if (UseCompressedOops) { if (UseCompressedOops) {
return enqueue_discovered_ref_helper<narrowOop>(this, task_executor); return enqueue_discovered_ref_helper<narrowOop>(this, task_executor);
} else { } else {
@ -651,18 +649,13 @@ ReferenceProcessor::clear_discovered_references(DiscoveredList& refs_list) {
refs_list.set_length(0); refs_list.set_length(0);
} }
void
ReferenceProcessor::abandon_partial_discovered_list(DiscoveredList& refs_list) {
clear_discovered_references(refs_list);
}
void ReferenceProcessor::abandon_partial_discovery() { void ReferenceProcessor::abandon_partial_discovery() {
// loop over the lists // loop over the lists
for (uint i = 0; i < _max_num_q * number_of_subclasses_of_ref(); i++) { for (uint i = 0; i < _max_num_q * number_of_subclasses_of_ref(); i++) {
if (TraceReferenceGC && PrintGCDetails && ((i % _max_num_q) == 0)) { if (TraceReferenceGC && PrintGCDetails && ((i % _max_num_q) == 0)) {
gclog_or_tty->print_cr("\nAbandoning %s discovered list", list_name(i)); gclog_or_tty->print_cr("\nAbandoning %s discovered list", list_name(i));
} }
abandon_partial_discovered_list(_discovered_refs[i]); clear_discovered_references(_discovered_refs[i]);
} }
} }
@ -1160,8 +1153,6 @@ void ReferenceProcessor::preclean_discovered_references(
GCTimer* gc_timer, GCTimer* gc_timer,
GCId gc_id) { GCId gc_id) {
NOT_PRODUCT(verify_ok_to_handle_reflists());
// Soft references // Soft references
{ {
GCTraceTime tt("Preclean SoftReferences", PrintGCDetails && PrintReferenceGC, GCTraceTime tt("Preclean SoftReferences", PrintGCDetails && PrintReferenceGC,
@ -1297,18 +1288,3 @@ const char* ReferenceProcessor::list_name(uint i) {
return NULL; return NULL;
} }
#ifndef PRODUCT
void ReferenceProcessor::verify_ok_to_handle_reflists() {
// empty for now
}
#endif
#ifndef PRODUCT
void ReferenceProcessor::clear_discovered_references() {
guarantee(!_discovering_refs, "Discovering refs?");
for (uint i = 0; i < _max_num_q * number_of_subclasses_of_ref(); i++) {
clear_discovered_references(_discovered_refs[i]);
}
}
#endif // PRODUCT

5
hotspot/src/share/vm/gc/shared/referenceProcessor.hpp
View file

@ -361,10 +361,8 @@ class ReferenceProcessor : public CHeapObj<mtGC> {
DiscoveredList* get_discovered_list(ReferenceType rt); DiscoveredList* get_discovered_list(ReferenceType rt);
inline void add_to_discovered_list_mt(DiscoveredList& refs_list, oop obj, inline void add_to_discovered_list_mt(DiscoveredList& refs_list, oop obj,
HeapWord* discovered_addr); HeapWord* discovered_addr);
void verify_ok_to_handle_reflists() PRODUCT_RETURN;
void clear_discovered_references(DiscoveredList& refs_list); void clear_discovered_references(DiscoveredList& refs_list);
void abandon_partial_discovered_list(DiscoveredList& refs_list);
// Calculate the number of jni handles. // Calculate the number of jni handles.
unsigned int count_jni_refs(); unsigned int count_jni_refs();
@ -457,9 +455,6 @@ class ReferenceProcessor : public CHeapObj<mtGC> {
// debugging // debugging
void verify_no_references_recorded() PRODUCT_RETURN; void verify_no_references_recorded() PRODUCT_RETURN;
void verify_referent(oop obj) PRODUCT_RETURN; void verify_referent(oop obj) PRODUCT_RETURN;
// clear the discovered lists (unlinking each entry).
void clear_discovered_references() PRODUCT_RETURN;
}; };
// A utility class to disable reference discovery in // A utility class to disable reference discovery in