archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-18 01:54:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8228630: Remove always true parameter to NoSafepointVerifier

Browse source 
Also remove NoGCVerifier since NoSafepointVerifier covers GC checking when not already at a safepoint and is a stronger check.

Reviewed-by: kbarrett, dholmes
This commit is contained in:
Coleen Phillimore 2019-07-31 06:54:50 -04:00
parent 9ad5641ce5
commit ab9aab646b
11 changed files with 69 additions and 226 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/hotspot/share/runtime/thread.cpp
View file

@ -250,7 +250,7 @@ Thread::Thread() {
// plain initialization
debug_only(_owned_locks = NULL;)
NOT_PRODUCT(_allow_safepoint_count = 0;)
NOT_PRODUCT(_no_safepoint_count = 0;)
NOT_PRODUCT(_skip_gcalot = false;)
_jvmti_env_iteration_count = 0;
set_allocated_bytes(0);
@ -1020,7 +1020,7 @@ bool Thread::owns_locks_but_compiled_lock() const {
// no locks which allow_vm_block's are held
void Thread::check_for_valid_safepoint_state(bool potential_vm_operation) {
// Check if current thread is allowed to block at a safepoint
if (!(_allow_safepoint_count == 0)) {
if (_no_safepoint_count > 0) {
fatal("Possible safepoint reached by thread that does not allow it");
}
if (is_Java_thread() && ((JavaThread*)this)->thread_state() != _thread_in_vm) {
@ -3543,7 +3543,7 @@ static inline void *prefetch_and_load_ptr(void **addr, intx prefetch_interval) {
// All NonJavaThreads (i.e., every non-JavaThread in the system).
void Threads::non_java_threads_do(ThreadClosure* tc) {
NoSafepointVerifier nsv(!SafepointSynchronize::is_at_safepoint(), false);
NoSafepointVerifier nsv;
for (NonJavaThread::Iterator njti; !njti.end(); njti.step()) {
tc->do_thread(njti.current());
}