archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 06:45:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

6621144: CMS: assertion failure "is_cms_thread == Thread::current()->is_ConcurrentGC_thread()"

Browse source 
Take lock conditionally (in asynchronous mode only) when updating the dead-object map.

Reviewed-by: jmasa
This commit is contained in:
Y. Srinivas Ramakrishna 2008-02-16 22:41:20 -08:00
parent 38fdc8ab98
commit ae065e6290
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
View file

@ -5732,13 +5732,19 @@ void CMSCollector::sweep(bool asynch) {
// in the perm_gen_verify_bit_map. In order to do that we traverse // in the perm_gen_verify_bit_map. In order to do that we traverse
// all blocks in perm gen and mark all dead objects. // all blocks in perm gen and mark all dead objects.
if (verifying() && !cms_should_unload_classes()) { if (verifying() && !cms_should_unload_classes()) {
CMSTokenSyncWithLocks ts(true, _permGen->freelistLock(),
bitMapLock());
assert(perm_gen_verify_bit_map()->sizeInBits() != 0, assert(perm_gen_verify_bit_map()->sizeInBits() != 0,
"Should have already been allocated"); "Should have already been allocated");
MarkDeadObjectsClosure mdo(this, _permGen->cmsSpace(), MarkDeadObjectsClosure mdo(this, _permGen->cmsSpace(),
markBitMap(), perm_gen_verify_bit_map()); markBitMap(), perm_gen_verify_bit_map());
_permGen->cmsSpace()->blk_iterate(&mdo); if (asynch) {
CMSTokenSyncWithLocks ts(true, _permGen->freelistLock(),
bitMapLock());
_permGen->cmsSpace()->blk_iterate(&mdo);
} else {
// In the case of synchronous sweep, we already have
// the requisite locks/tokens.
_permGen->cmsSpace()->blk_iterate(&mdo);
}
} }
if (asynch) { if (asynch) {