archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 17:44:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8063112: Compiler diagnostic commands should have locking instead of safepoint

Browse source 
Remove unnecessary vm-ops and add locking instead, improve output

Reviewed-by: kvn
This commit is contained in:
Nils Eliasson 2016-01-22 15:25:40 +01:00
parent 56c2dccccf
commit ae0867c9f8
8 changed files with 48 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

32
hotspot/src/share/vm/runtime/thread.cpp
View file

@ -31,6 +31,7 @@
#include "code/codeCacheExtensions.hpp"
#include "code/scopeDesc.hpp"
#include "compiler/compileBroker.hpp"
#include "compiler/compileTask.hpp"
#include "gc/shared/gcId.hpp"
#include "gc/shared/gcLocker.inline.hpp"
#include "gc/shared/workgroup.hpp"
@ -2884,6 +2885,20 @@ void JavaThread::print_on(outputStream *st) const {
print_thread_state_on(st);
_safepoint_state->print_on(st);
#endif // PRODUCT
if (is_Compiler_thread()) {
CompilerThread* ct = (CompilerThread*)this;
if (ct->task() != NULL) {
st->print(" Compiling: ");
ct->task()->print(st, NULL, true, false);
} else {
st->print(" No compile task");
}
st->cr();
}
}
void JavaThread::print_name_on_error(outputStream* st, char *buf, int buflen) const {
st->print("%s", get_thread_name_string(buf, buflen));
}
// Called by fatal error handler. The difference between this and
@ -4386,7 +4401,6 @@ void Threads::print_on(outputStream* st, bool print_stacks,
wt->print_on(st);
st->cr();
}
CompileBroker::print_compiler_threads_on(st);
st->flush();
}
@ -4439,8 +4453,24 @@ void Threads::print_on_error(outputStream* st, Thread* current, char* buf,
current->print_on_error(st, buf, buflen);
st->cr();
}
st->cr();
st->print_cr("Threads with active compile tasks:");
print_threads_compiling(st, buf, buflen);
}
void Threads::print_threads_compiling(outputStream* st, char* buf, int buflen) {
ALL_JAVA_THREADS(thread) {
if (thread->is_Compiler_thread()) {
CompilerThread* ct = (CompilerThread*) thread;
if (ct->task() != NULL) {
thread->print_name_on_error(st, buf, buflen);
ct->task()->print(st, NULL, true, true);
}
}
}
}
// Internal SpinLock and Mutex
// Based on ParkEvent