archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-21 11:34:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

6860795: NullPointerException when compiling a negative java source

Browse source 
Rich formatter shouldn't propagate visits on method symbols that have a null type

Reviewed-by: jjg
This commit is contained in:
Maurizio Cimadamore 2009-07-15 17:01:47 +01:00
parent dd76763423
commit ae2586d2c3
3 changed files with 38 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
langtools/src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java
View file

@ -569,6 +569,7 @@ public class RichDiagnosticFormatter extends
@Override @Override
public Void visitMethodSymbol(MethodSymbol s, Void ignored) { public Void visitMethodSymbol(MethodSymbol s, Void ignored) {
visit(s.owner, null); visit(s.owner, null);
if (s.type != null)
typePreprocessor.visit(s.type); typePreprocessor.visit(s.type);
return null; return null;
} }

34
langtools/test/tools/javac/Diagnostics/6860795/T6860795.java Normal file
View file

@ -0,0 +1,34 @@
/*
* Copyright 2009 Sun Microsystems, Inc. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
* CA 95054 USA or visit www.sun.com if you need additional information or
* have any questions.
*/
/**
* @test
* @bug 6860795
* @summary NullPointerException when compiling a negative java source
* @author mcimadamore
* @compile/fail/ref=T6860795.out -XDrawDiagnostics T6860795.java
*/
class Test {
void foo(float x, int x) {}
}

2
langtools/test/tools/javac/Diagnostics/6860795/T6860795.out Normal file
View file

@ -0,0 +1,2 @@
T6860795.java:33:27: compiler.err.already.defined: x, foo
1 error