archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 07:14:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8202252: (aio) Closed AsynchronousSocketChannel keeps completion handler alive

Browse source 
Clear handler instance variable after use

Reviewed-by: rriggs, alanb
This commit is contained in:
Brian Burkhalter 2018-07-03 15:02:46 -07:00
parent 0a99860ff9
commit aef5f86408
2 changed files with 215 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2008, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2008, 2018, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -273,6 +273,7 @@ class UnixAsynchronousSocketChannelImpl
// invoke handler and set result
CompletionHandler<Void,Object> handler = connectHandler;
connectHandler = null;
Object att = connectAttachment;
PendingFuture<Void,Object> future = connectFuture;
if (handler == null) {
@ -405,6 +406,7 @@ class UnixAsynchronousSocketChannelImpl
this.readBuffer = null;
this.readBuffers = null;
this.readAttachment = null;
this.readHandler = null;
// allow another read to be initiated
enableReading();
@ -600,6 +602,7 @@ class UnixAsynchronousSocketChannelImpl
this.writeBuffer = null;
this.writeBuffers = null;
this.writeAttachment = null;
this.writeHandler = null;
// allow another write to be initiated
enableWriting();