archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8284742: x86: Handle integral division overflow during parsing

Browse source 
Reviewed-by: kvn, mdoerr
This commit is contained in:
Quan Anh Mai 2022-04-20 16:17:01 +00:00 • committed by Vladimir Kozlov
parent 5291ec8d56
commit b4a85cdae1
24 changed files with 648 additions and 378 deletions
Download patch file Download diff file Expand all files Collapse all files

38
test/micro/org/openjdk/bench/java/lang/IntegerDivMod.java
View file

@ -24,6 +24,7 @@ package org.openjdk.bench.java.lang;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
import org.openjdk.jmh.annotations.Scope;
@ -34,12 +35,10 @@ import java.util.random.RandomGenerator;
import java.util.random.RandomGeneratorFactory;
import java.util.concurrent.TimeUnit;
/**
* Tests unsigned division and modulus methods in java.lang.Integer
*/
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@State(Scope.Thread)
@Fork(1)
public class IntegerDivMod {
RandomGenerator randomGenerator;
@ -60,12 +59,37 @@ public class IntegerDivMod {
for (int i = 0; i < BUFFER_SIZE; i++) {
dividends[i] = rng.nextInt();
int divisor = rng.nextInt();
if (divisorType.equals("positive")) divisor = Math.abs(divisor);
else if (divisorType.equals("negative")) divisor = -Math.abs(divisor);
if (divisorType.equals("positive")) {
divisor = Math.abs(divisor);
} else if (divisorType.equals("negative")) {
divisor = -Math.abs(divisor);
}
divisors[i] = divisor;
}
}
@Benchmark
public void testDivide() {
for (int i = 0; i < BUFFER_SIZE; i++) {
quotients[i] = dividends[i] / divisors[i];
}
}
@Benchmark
public void testDivideKnownPositive() {
for (int i = 0; i < BUFFER_SIZE; i++) {
quotients[i] = dividends[i] / Math.max(1, divisors[i]);
}
}
@Benchmark
public void testDivideHoistedDivisor() {
int x = divisors[0];
for (int i = 0; i < BUFFER_SIZE; i++) {
quotients[i] = dividends[i] / x;
}
}
@Benchmark
public void testDivideUnsigned() {
for (int i = 0; i < BUFFER_SIZE; i++) {
@ -91,8 +115,4 @@ public class IntegerDivMod {
quotients[i] = Integer.divideUnsigned(dividend, divisor);
remainders[i] = Integer.remainderUnsigned(dividend, divisor);
}
}