archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-22 20:14:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8076344: serviceability/dcmd/vm/SetVMFlagTest.java test fails with "java.lang.Error: 'MaxHeapSize' flag is not available or immutable"

Browse source 
Reviewed-by: sla
This commit is contained in:
Jaroslav Bachorik 2015-04-02 12:14:43 +02:00
parent afa2dbda46
commit b89433f7cd
2 changed files with 54 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

49
hotspot/test/serviceability/dcmd/vm/SetVMFlagTest.java
View file

@ -38,13 +38,10 @@ import static org.testng.Assert.*;
*/ */
public class SetVMFlagTest { public class SetVMFlagTest {
private static final String PRINTGC_NAME = "PrintGC"; private static final String MANAGEABLE_PATTERN = "\\s*bool\\s+(\\S+)\\s+[\\:]?=\\s+" +
private static final String XMX_NAME = "MaxHeapSize"; "(.*?)\\s+\\{manageable\\}";
private static final String IMMUTABLE_PATTERN = "\\s*uintx\\s+(\\S+)\\s+[\\:]?=\\s+" +
private static final String PRINTGC_PATTERN = "\\s*bool " + PRINTGC_NAME + "(.*?)\\s+\\{product\\}";
"\\s+[\\:]?=\\s+(.*?)\\s+\\{manageable\\}";
private static final String XMX_PATTERN = "\\s*uintx " + XMX_NAME +
"\\s+[\\:]?=\\s+(.*?)\\s+\\{product\\}";
public void run(CommandExecutor executor) { public void run(CommandExecutor executor) {
setMutableFlag(executor); setMutableFlag(executor);
@ -60,76 +57,86 @@ public class SetVMFlagTest {
private void setMutableFlag(CommandExecutor executor) { private void setMutableFlag(CommandExecutor executor) {
OutputAnalyzer out = getAllFlags(executor); OutputAnalyzer out = getAllFlags(executor);
String flagVal = out.firstMatch(PRINTGC_PATTERN, 1); String flagName = out.firstMatch(MANAGEABLE_PATTERN, 1);
String flagVal = out.firstMatch(MANAGEABLE_PATTERN, 2);
System.out.println("### Setting a mutable flag '" + flagName + "'");
if (flagVal == null) { if (flagVal == null) {
System.err.println(out.getOutput()); System.err.println(out.getOutput());
throw new Error("'" + PRINTGC_NAME + "' flag is either not available or manageable"); throw new Error("Can not find a boolean manageable flag");
} }
Boolean blnVal = Boolean.parseBoolean(flagVal); Boolean blnVal = Boolean.parseBoolean(flagVal);
out = executor.execute("VM.set_flag " + PRINTGC_NAME + " " + (blnVal ? 0 : 1)); out = executor.execute("VM.set_flag " + flagName + " " + (blnVal ? 0 : 1));
out.stderrShouldBeEmpty(); out.stderrShouldBeEmpty();
out = getAllFlags(executor); out = getAllFlags(executor);
String newFlagVal = out.firstMatch(PRINTGC_PATTERN, 1); String newFlagVal = out.firstMatch(MANAGEABLE_PATTERN.replace("(\\S+)", flagName), 1);
assertNotEquals(newFlagVal, flagVal); assertNotEquals(newFlagVal, flagVal);
} }
private void setMutableFlagWithInvalidValue(CommandExecutor executor) { private void setMutableFlagWithInvalidValue(CommandExecutor executor) {
OutputAnalyzer out = getAllFlags(executor); OutputAnalyzer out = getAllFlags(executor);
String flagVal = out.firstMatch(PRINTGC_PATTERN, 1); String flagName = out.firstMatch(MANAGEABLE_PATTERN, 1);
String flagVal = out.firstMatch(MANAGEABLE_PATTERN, 2);
System.out.println("### Setting a mutable flag '" + flagName + "' to an invalid value");
if (flagVal == null) { if (flagVal == null) {
System.err.println(out.getOutput()); System.err.println(out.getOutput());
throw new Error("'" + PRINTGC_NAME + "' flag is either not available or manageable"); throw new Error("Can not find a boolean manageable flag");
} }
// PrintGC is a boolean flag and accepts only 0/1 as its value // a boolean flag accepts only 0/1 as its value
out = executor.execute("VM.set_flag " + PRINTGC_NAME + " unexpected_value"); out = executor.execute("VM.set_flag " + flagName + " unexpected_value");
out.stderrShouldBeEmpty(); out.stderrShouldBeEmpty();
out.stdoutShouldContain("flag value must be a boolean (1 or 0)"); out.stdoutShouldContain("flag value must be a boolean (1 or 0)");
out = getAllFlags(executor); out = getAllFlags(executor);
String newFlagVal = out.firstMatch(PRINTGC_PATTERN, 1); String newFlagVal = out.firstMatch(MANAGEABLE_PATTERN.replace("(\\S+)", flagName), 1);
assertEquals(newFlagVal, flagVal); assertEquals(newFlagVal, flagVal);
} }
private void setImmutableFlag(CommandExecutor executor) { private void setImmutableFlag(CommandExecutor executor) {
OutputAnalyzer out = getAllFlags(executor); OutputAnalyzer out = getAllFlags(executor);
String flagVal = out.firstMatch(XMX_PATTERN, 1); String flagName = out.firstMatch(IMMUTABLE_PATTERN, 1);
String flagVal = out.firstMatch(IMMUTABLE_PATTERN, 2);
System.out.println("### Setting an immutable flag '" + flagName + "'");
if (flagVal == null) { if (flagVal == null) {
System.err.println(out.getOutput()); System.err.println(out.getOutput());
throw new Error("'" + XMX_NAME + "' flag is not available or immutable"); throw new Error("Can not find an immutable uintx flag");
} }
Long numVal = Long.parseLong(flagVal); Long numVal = Long.parseLong(flagVal);
out = executor.execute("VM.set_flag " + XMX_NAME + " " + (numVal + 1)); out = executor.execute("VM.set_flag " + flagName + " " + (numVal + 1));
out.stderrShouldBeEmpty(); out.stderrShouldBeEmpty();
out.stdoutShouldContain("only 'writeable' flags can be set"); out.stdoutShouldContain("only 'writeable' flags can be set");
out = getAllFlags(executor); out = getAllFlags(executor);
String newFlagVal = out.firstMatch(XMX_PATTERN, 1); String newFlagVal = out.firstMatch(IMMUTABLE_PATTERN.replace("(\\S+)", flagName), 1);
assertEquals(newFlagVal, flagVal); assertEquals(newFlagVal, flagVal);
} }
private void setNonExistingFlag(CommandExecutor executor) { private void setNonExistingFlag(CommandExecutor executor) {
String unknownFlag = "ThisIsUnknownFlag"; String unknownFlag = "ThisIsUnknownFlag";
System.out.println("### Setting a non-existing flag '" + unknownFlag + "'");
OutputAnalyzer out = executor.execute("VM.set_flag " + unknownFlag + " 1"); OutputAnalyzer out = executor.execute("VM.set_flag " + unknownFlag + " 1");
out.stderrShouldBeEmpty(); out.stderrShouldBeEmpty();
out.stdoutShouldContain("flag " + unknownFlag + " does not exist"); out.stdoutShouldContain("flag " + unknownFlag + " does not exist");
} }
private OutputAnalyzer getAllFlags(CommandExecutor executor) { private OutputAnalyzer getAllFlags(CommandExecutor executor) {
return executor.execute("VM.flags -all"); return executor.execute("VM.flags -all", true);
} }
} }

34
hotspot/test/testlibrary/com/oracle/java/testlibrary/dcmd/CommandExecutor.java
View file

@ -40,16 +40,34 @@ public abstract class CommandExecutor {
* stderr, regardless of the specific executor used. * stderr, regardless of the specific executor used.
*/ */
public final OutputAnalyzer execute(String cmd) throws CommandExecutorException { public final OutputAnalyzer execute(String cmd) throws CommandExecutorException {
System.out.printf("Running DCMD '%s' through '%s'%n", cmd, this.getClass().getSimpleName()); return execute(cmd, false);
}
/**
* Execute a diagnostic command
*
* @param cmd The diagnostic command to execute
* @param silent Do not print the command output
* @return an {@link jdk.testlibrary.OutputAnalyzer} encapsulating the output of the command
* @throws CommandExecutorException if there is an exception on the "calling side" while trying to execute the
* Diagnostic Command. Exceptions thrown on the remote side are available as textual representations in
* stderr, regardless of the specific executor used.
*/
public final OutputAnalyzer execute(String cmd, boolean silent) throws CommandExecutorException {
if (!silent) {
System.out.printf("Running DCMD '%s' through '%s'%n", cmd, this.getClass().getSimpleName());
}
OutputAnalyzer oa = executeImpl(cmd); OutputAnalyzer oa = executeImpl(cmd);
System.out.println("---------------- stdout ----------------"); if (!silent) {
System.out.println(oa.getStdout()); System.out.println("---------------- stdout ----------------");
System.out.println("---------------- stderr ----------------"); System.out.println(oa.getStdout());
System.out.println(oa.getStderr()); System.out.println("---------------- stderr ----------------");
System.out.println("----------------------------------------"); System.out.println(oa.getStderr());
System.out.println(); System.out.println("----------------------------------------");
System.out.println();
}
return oa; return oa;
} }