archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 23:34:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll

Browse source 
Reviewed-by: chegar, dfuchs, aph
This commit is contained in:
Jonathan Dowland 2021-03-22 15:29:47 +00:00 • committed by Chris Hegarty
parent 0abbfb2fc5
commit ba504fcee8
3 changed files with 22 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/java.base/windows/native/libnet/NetworkInterface.c
View file

@ -641,8 +641,10 @@ jobject createNetworkInterface
return NULL;
}
(*env)->SetObjectField(env, ibObj, ni_ibbroadcastID, ia2Obj);
(*env)->DeleteLocalRef(env, ia2Obj);
(*env)->SetShortField(env, ibObj, ni_ibmaskID, addrs->mask);
(*env)->SetObjectArrayElement(env, bindsArr, bind_index++, ibObj);
(*env)->DeleteLocalRef(env, ibObj);
}
} else /* AF_INET6 */ {
int scope;
@ -667,9 +669,11 @@ jobject createNetworkInterface
(*env)->SetObjectField(env, ibObj, ni_ibaddressID, iaObj);
(*env)->SetShortField(env, ibObj, ni_ibmaskID, addrs->mask);
(*env)->SetObjectArrayElement(env, bindsArr, bind_index++, ibObj);
(*env)->DeleteLocalRef(env, ibObj);
}
}
(*env)->SetObjectArrayElement(env, addrArr, addr_index, iaObj);
(*env)->DeleteLocalRef(env, iaObj);
addrs = addrs->next;
addr_index++;
}
@ -677,6 +681,10 @@ jobject createNetworkInterface
(*env)->SetObjectField(env, netifObj, ni_bindsID, bindsArr);
free_netaddr(netaddrP);
(*env)->DeleteLocalRef(env, name);
(*env)->DeleteLocalRef(env, displayName);
(*env)->DeleteLocalRef(env, addrArr);
(*env)->DeleteLocalRef(env, bindsArr);
/*
* Windows doesn't have virtual interfaces, so child array
@ -687,6 +695,7 @@ jobject createNetworkInterface
return NULL;
}
(*env)->SetObjectField(env, netifObj, ni_childsID, childArr);
(*env)->DeleteLocalRef(env, childArr);
/* return the NetworkInterface */
return netifObj;
@ -959,6 +968,7 @@ JNIEXPORT jobjectArray JNICALL Java_java_net_NetworkInterface_getAll
/* put the NetworkInterface into the array */
(*env)->SetObjectArrayElement(env, netIFArr, arr_index++, netifObj);
(*env)->DeleteLocalRef(env, netifObj);
curr = curr->next;
}