archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 07:14:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8029383: assert(counter_changed) failed: failed dependencies, but counter didn't change

Browse source 
No call to SystemDictionary::notice_modification() when class is defined through Unsafe.defineAnonymousClass() can caused missed dependency change.

Reviewed-by: kvn, twisti
This commit is contained in:
Roland Westrelin 2013-12-13 09:25:44 +01:00
parent da079783f8
commit bbb97e5b39
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
hotspot/src/share/vm/classfile/systemDictionary.cpp
View file

@ -1049,6 +1049,9 @@ Klass* SystemDictionary::parse_stream(Symbol* class_name,
add_to_hierarchy(k, CHECK_NULL); // No exception, but can block add_to_hierarchy(k, CHECK_NULL); // No exception, but can block
// But, do not add to system dictionary. // But, do not add to system dictionary.
// compiled code dependencies need to be validated anyway
notice_modification();
} }
// Rewrite and patch constant pool here. // Rewrite and patch constant pool here.

3
hotspot/src/share/vm/prims/jvmtiRedefineClasses.cpp
View file

@ -147,9 +147,6 @@ void VM_RedefineClasses::doit() {
_scratch_classes[i] = NULL; _scratch_classes[i] = NULL;
} }
// Disable any dependent concurrent compilations
SystemDictionary::notice_modification();
// Set flag indicating that some invariants are no longer true. // Set flag indicating that some invariants are no longer true.
// See jvmtiExport.hpp for detailed explanation. // See jvmtiExport.hpp for detailed explanation.
JvmtiExport::set_has_redefined_a_class(); JvmtiExport::set_has_redefined_a_class();