archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 17:44:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8223585: vmTestbase/runtime/pcl/* get SEGV in MetadataOnStackClosure::do_metadata(Metadata*)+0x0

Browse source 
Adjust old method table by only one thread.

Reviewed-by: kvn, jcbeyler, sspitsyn
This commit is contained in:
Coleen Phillimore 2019-05-16 11:07:09 -04:00
parent 08193be19c
commit bc264ba95b
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/hotspot/share/code/codeCache.cpp
View file

@ -1055,7 +1055,7 @@ static void reset_old_method_table() {
// Remove this method when zombied or unloaded.
void CodeCache::unregister_old_nmethod(CompiledMethod* c) {
assert_locked_or_safepoint(CodeCache_lock);
assert_lock_strong(CodeCache_lock);
if (old_compiled_method_table != NULL) {
int index = old_compiled_method_table->find(c);
if (index != -1) {
@ -1070,7 +1070,11 @@ void CodeCache::old_nmethods_do(MetadataClosure* f) {
if (old_compiled_method_table != NULL) {
length = old_compiled_method_table->length();
for (int i = 0; i < length; i++) {
old_compiled_method_table->at(i)->metadata_do(f);
CompiledMethod* cm = old_compiled_method_table->at(i);
// Only walk alive nmethods, the dead ones will get removed by the sweeper.
if (cm->is_alive()) {
old_compiled_method_table->at(i)->metadata_do(f);
}
}
}
log_debug(redefine, class, nmethod)("Walked %d nmethods for mark_on_stack", length);