archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8245678: Avoid allocations in Executable.getAllGenericParameterTypes

Browse source 
Reviewed-by: jlaskey, redestad
This commit is contained in:
Christoph Dreis 2020-05-25 22:26:18 +02:00 • committed by Claes Redestad
parent 742d35e08a
commit bc822ffad8
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/java.base/share/classes/java/lang/reflect/Executable.java
View file

@ -307,12 +307,12 @@ public abstract class Executable extends AccessibleObject
final boolean realParamData = hasRealParameterData(); final boolean realParamData = hasRealParameterData();
final Type[] genericParamTypes = getGenericParameterTypes(); final Type[] genericParamTypes = getGenericParameterTypes();
final Type[] nonGenericParamTypes = getParameterTypes(); final Type[] nonGenericParamTypes = getParameterTypes();
final Type[] out = new Type[nonGenericParamTypes.length];
final Parameter[] params = getParameters();
int fromidx = 0;
// If we have real parameter data, then we use the // If we have real parameter data, then we use the
// synthetic and mandate flags to our advantage. // synthetic and mandate flags to our advantage.
if (realParamData) { if (realParamData) {
final Type[] out = new Type[nonGenericParamTypes.length];
final Parameter[] params = getParameters();
int fromidx = 0;
for (int i = 0; i < out.length; i++) { for (int i = 0; i < out.length; i++) {
final Parameter param = params[i]; final Parameter param = params[i];
if (param.isSynthetic() || param.isImplicit()) { if (param.isSynthetic() || param.isImplicit()) {
@ -325,6 +325,7 @@ public abstract class Executable extends AccessibleObject
fromidx++; fromidx++;
} }
} }
return out;
} else { } else {
// Otherwise, use the non-generic parameter data. // Otherwise, use the non-generic parameter data.
// Without method parameter reflection data, we have // Without method parameter reflection data, we have
@ -334,7 +335,6 @@ public abstract class Executable extends AccessibleObject
return genericParamTypes.length == nonGenericParamTypes.length ? return genericParamTypes.length == nonGenericParamTypes.length ?
genericParamTypes : nonGenericParamTypes; genericParamTypes : nonGenericParamTypes;
} }
return out;
} }
} }