archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8244719: CTW: C2 compilation fails with "assert(!VerifyHashTableKeys || _hash_lock == 0) failed: remove node from hash table before modifying it"

Browse source 
Fix Parse::Block::init_graph() to also count predecessors for exception blocks because they can have a direct bytecode jump to them resulting in this assertion failure.

Reviewed-by: kvn, thartmann
This commit is contained in:
Christian Hagedorn 2020-06-10 17:56:23 +02:00
parent 847a3baca8
commit bf22f82207
3 changed files with 225 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

46
test/hotspot/jtreg/compiler/parsing/TestExceptionBlockWithPredecessorsMain.java Normal file
View file

@ -0,0 +1,46 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8244719
* @summary Tests custom bytecode with an explicit entry (fall through or jump) to an exception block which was unexpected for C2 parsing.
*
* @compile TestExceptionBlockWithPredecessors.jasm
* @run main/othervm -Xbatch -XX:CompileCommand=dontinline,compiler.parsing.TestExceptionBlockWithPredecessors::*
* compiler.parsing.TestExceptionBlockWithPredecessorsMain
*/
package compiler.parsing;
public class TestExceptionBlockWithPredecessorsMain {
public static void main(String[] args) {
TestExceptionBlockWithPredecessors t = new TestExceptionBlockWithPredecessors();
for (int i = 0; i < 10000; i++) {
t.loopCounter = (i % 2 == 0) ? 0 : 10;
t.switchOn = (i % 2 == 0) ? 2 : 3;
t.test(); // Triggers assertion failure
t.testWorksWithoutPreds(); // Works since no predecessors for exception handler
}
}
}