archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 06:45:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8273026: Slow LoginContext.login() on multi threading application

Browse source 
Reviewed-by: weijun
This commit is contained in:
Ilarion Nakonechnyy 2021-10-29 11:37:45 +00:00 • committed by Weijun Wang
parent 15fd8a300b
commit c0cda1db4f
3 changed files with 36 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

39
src/java.base/share/classes/javax/security/auth/login/LoginContext.java
View file

@ -40,6 +40,10 @@ import java.util.ServiceLoader;
import sun.security.util.PendingException;
import sun.security.util.ResourcesMgr;
import java.util.Set;
import java.util.WeakHashMap;
import java.util.stream.*;
import java.util.ServiceLoader.Provider;
/**
* <p> The {@code LoginContext} class describes the basic methods used
* to authenticate Subjects and provides a way to develop an
@ -222,6 +226,8 @@ public class LoginContext {
private static final sun.security.util.Debug debug =
sun.security.util.Debug.getInstance("logincontext", "\t[LoginContext]");
private static final WeakHashMap<ClassLoader, Set<Provider<LoginModule>>> providersCache =
new WeakHashMap<>();
@SuppressWarnings("removal")
private void init(String name) throws LoginException {
@ -288,6 +294,7 @@ public class LoginContext {
return loader;
}
});
}
@SuppressWarnings("removal")
@ -691,21 +698,35 @@ public class LoginContext {
// locate and instantiate the LoginModule
//
String name = moduleStack[i].entry.getLoginModuleName();
@SuppressWarnings("removal")
ServiceLoader<LoginModule> sc = AccessController.doPrivileged(
(PrivilegedAction<ServiceLoader<LoginModule>>)
() -> ServiceLoader.load(
LoginModule.class, contextClassLoader));
for (LoginModule m: sc) {
if (m.getClass().getName().equals(name)) {
moduleStack[i].module = m;
Set<Provider<LoginModule>> lmProviders;
synchronized(providersCache){
lmProviders = providersCache.get(contextClassLoader);
if (lmProviders == null){
if (debug != null){
debug.println("Build ServiceProviders cache for ClassLoader: " + contextClassLoader.getName());
}
@SuppressWarnings("removal")
ServiceLoader<LoginModule> sc = AccessController.doPrivileged(
(PrivilegedAction<ServiceLoader<LoginModule>>)
() -> java.util.ServiceLoader.load(
LoginModule.class, contextClassLoader));
lmProviders = sc.stream().collect(Collectors.toSet());
if (debug != null){
debug.println("Discovered ServiceProviders for ClassLoader: " + contextClassLoader.getName());
lmProviders.forEach(System.err::println);
}
providersCache.put(contextClassLoader,lmProviders);
}
}
for (Provider<LoginModule> lm: lmProviders){
if (lm.type().getName().equals(name)){
moduleStack[i].module = lm.get();
if (debug != null) {
debug.println(name + " loaded as a service");
}
break;
}
}
if (moduleStack[i].module == null) {
try {
@SuppressWarnings("deprecation")