archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-19 10:34:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8170594: >>>=0 generates invalid bytecode for BaseNode LHS

Browse source 
Reviewed-by: jlaskey, sundar
This commit is contained in:
Attila Szegedi 2016-12-01 14:37:39 +01:00
parent fa4bdd39c5
commit c3c7c2e7f9
2 changed files with 46 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/CodeGenerator.java
View file

@ -4066,7 +4066,7 @@ final class CodeGenerator extends NodeOperatorVisitor<CodeGeneratorLexicalContex
void loadStack() {
assert assignNode.getWidestOperandType() == Type.INT;
if (isRhsZero(binaryNode)) {
loadExpressionAsType(binaryNode.lhs(), Type.INT);
loadExpression(binaryNode.lhs(), TypeBounds.INT, true);
} else {
loadBinaryOperands(binaryNode.lhs(), binaryNode.rhs(), TypeBounds.INT, true, false);
method.shr();

45
nashorn/test/script/basic/JDK-8170594.js Normal file
View file

@ -0,0 +1,45 @@
/*
* Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8170594: >>>=0 generates invalid bytecode for BaseNode LHS
*
* @test
* @run
*/
var obj1 = {x: "100"};
(function (o, p) {
if (p) {
o.x >>>= 0;
}
})(obj1, true)
Assert.assertTrue(obj1.x === 100)
var obj2 = ["100"];
(function (o, p) {
if (p) {
o[0] >>>= 0;
}
})(obj2, true)
Assert.assertTrue(obj2[0] === 100)