8155880: Fix langtools usage of the deprecated Class.newInstance method

Reviewed-by: mcimadamore

langtools/src/java.compiler/share/classes/javax/tools/ToolProvider.java

@@ -125,9 +125,8 @@ public class ToolProvider {
     private static <T> T getSystemTool(Class<T> clazz, String moduleName, String className) {
         if (useLegacy) {
             try {
-                @SuppressWarnings("deprecation")
+                return Class.forName(className, true, ClassLoader.getSystemClassLoader()).
-                T result = Class.forName(className, true, ClassLoader.getSystemClassLoader()).asSubclass(clazz).newInstance();
+                    asSubclass(clazz).getConstructor().newInstance();
-                return result;
             } catch (ReflectiveOperationException e) {
                 throw new Error(e);
             }

langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java

@@ -31,6 +31,7 @@ import java.io.IOException;
 import java.io.PrintWriter;
 import java.io.StringWriter;
 import java.lang.reflect.Method;
+import java.lang.reflect.Constructor;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.nio.file.Path;
@@ -282,9 +283,7 @@ public class JavacProcessingEnvironment implements ProcessingEnvironment, Closea
 
         if (options.isSet(XPRINT)) {
             try {
-                @SuppressWarnings("deprecation")
+                processorIterator = List.of(new PrintingProcessor()).iterator();
-                Processor processor = PrintingProcessor.class.newInstance();
-                processorIterator = List.of(processor).iterator();
             } catch (Throwable t) {
                 AssertionError assertError =
                     new AssertionError("Problem instantiating PrintingProcessor.");
@@ -540,39 +539,41 @@ public class JavacProcessingEnvironment implements ProcessingEnvironment, Closea
             if (nextProc != null)
                 return true;
             else {
-                if (!names.hasNext())
+                if (!names.hasNext()) {
                     return false;
-                else {
+                } else {
-                    String processorName = names.next();
+                    Processor processor = getNextProcessor(names.next());
+                    if (processor == null) {
+                        return false;
+                    } else {
+                        nextProc = processor;
+                        return true;
+                    }
+                }
+            }
+        }
 
-                    Processor processor;
+        private Processor getNextProcessor(String processorName) {
             try {
                 try {
                     Class<?> processorClass = processorCL.loadClass(processorName);
                     ensureReadable(processorClass);
-                            @SuppressWarnings("deprecation")
+                    return (Processor) processorClass.getConstructor().newInstance();
-                            Object tmp = processorClass.newInstance();
-                            processor = (Processor) tmp;
                 } catch (ClassNotFoundException cnfe) {
                     log.error("proc.processor.not.found", processorName);
-                            return false;
+                    return null;
                 } catch (ClassCastException cce) {
                     log.error("proc.processor.wrong.type", processorName);
-                            return false;
+                    return null;
                 } catch (Exception e ) {
                     log.error("proc.processor.cant.instantiate", processorName);
-                            return false;
+                    return null;
                 }
             } catch (ClientCodeException e) {
                 throw e;
             } catch (Throwable t) {
                 throw new AnnotationProcessingError(t);
             }
-                    nextProc = processor;
-                    return true;
-                }
-
-            }
         }
 
         public Processor next() {

langtools/src/jdk.compiler/share/classes/com/sun/tools/sjavac/options/Option.java

@@ -151,8 +151,8 @@ public enum Option {
             // Construct transformer
             try {
                 Class<?> trCls = Class.forName(classname);
-                @SuppressWarnings("deprecation")
+                Transformer transformer =
-                Transformer transformer = (Transformer) trCls.newInstance();
+                    (Transformer) trCls.getConstructor().newInstance();
                 transformer.setExtra(extra);
                 helper.addTransformer(suffix, transformer);
             } catch (Exception e) {

langtools/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java

@@ -252,8 +252,7 @@ public class TagletManager {
             }
             tagClassLoader = fileManager.getClassLoader(TAGLET_PATH);
             Class<?> customTagClass = tagClassLoader.loadClass(classname);
-            @SuppressWarnings("deprecation")
+            Object instance = customTagClass.getConstructor().newInstance();
-            Object instance = customTagClass.newInstance();
             Taglet newLegacy = new UserTaglet((jdk.javadoc.doclet.taglet.Taglet)instance);
             String tname = newLegacy.getName();
             Taglet t = customTags.get(tname);

langtools/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java

@@ -273,9 +273,9 @@ public class Start extends ToolOption.Helper {
             initMessager();
             messager.setLocale(locale);
             try {
-                Object o = docletClass.newInstance();
+                Object o = docletClass.getConstructor().newInstance();
                 doclet = (Doclet) o;
-            } catch (InstantiationException | IllegalAccessException exc) {
+            } catch (ReflectiveOperationException exc) {
                 exc.printStackTrace();
                 if (!apiMode) {
                     error("main.could_not_instantiate_class", docletClass);