archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8265079: Implement VarHandle invoker caching

Browse source 
Reviewed-by: redestad, vlivanov, psandoz, mchung
This commit is contained in:
Jorn Vernee 2021-04-19 11:36:55 +00:00
parent b64a3fb946
commit c88714875d
2 changed files with 111 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/java.base/share/classes/java/lang/invoke/Invokers.java
View file

@ -54,7 +54,9 @@ class Invokers {
INV_EXACT = 0, // MethodHandles.exactInvoker
INV_GENERIC = 1, // MethodHandles.invoker (generic invocation)
INV_BASIC = 2, // MethodHandles.basicInvoker
INV_LIMIT = 3;
VH_INV_EXACT = 3, // MethodHandles.varHandleExactInvoker
VH_INV_GENERIC = VH_INV_EXACT + VarHandle.AccessMode.values().length, // MethodHandles.varHandleInvoker
INV_LIMIT = VH_INV_GENERIC + VarHandle.AccessMode.values().length;
/** Compute and cache information common to all collecting adapters
* that implement members of the erasure-family of the given erased type.
@ -101,14 +103,20 @@ class Invokers {
/*non-public*/
MethodHandle varHandleMethodInvoker(VarHandle.AccessMode ak) {
// TODO cache invoker
return makeVarHandleMethodInvoker(ak, false);
boolean isExact = false;
MethodHandle invoker = cachedVHInvoker(isExact, ak);
if (invoker != null) return invoker;
invoker = makeVarHandleMethodInvoker(ak, isExact);
return setCachedVHInvoker(isExact, ak, invoker);
}
/*non-public*/
MethodHandle varHandleMethodExactInvoker(VarHandle.AccessMode ak) {
// TODO cache invoker
return makeVarHandleMethodInvoker(ak, true);
boolean isExact = true;
MethodHandle invoker = cachedVHInvoker(isExact, ak);
if (invoker != null) return invoker;
invoker = makeVarHandleMethodInvoker(ak, isExact);
return setCachedVHInvoker(isExact, ak, invoker);
}
private MethodHandle cachedInvoker(int idx) {
@ -122,6 +130,16 @@ class Invokers {
return invokers[idx] = invoker;
}
private MethodHandle cachedVHInvoker(boolean isExact, VarHandle.AccessMode ak) {
int baseIndex = (isExact ? VH_INV_EXACT : VH_INV_GENERIC);
return cachedInvoker(baseIndex + ak.ordinal());
}
private MethodHandle setCachedVHInvoker(boolean isExact, VarHandle.AccessMode ak, final MethodHandle invoker) {
int baseIndex = (isExact ? VH_INV_EXACT : VH_INV_GENERIC);
return setCachedInvoker(baseIndex + ak.ordinal(), invoker);
}
private MethodHandle makeExactOrGeneralInvoker(boolean isExact) {
MethodType mtype = targetType;
MethodType invokerType = mtype.invokerType();