archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-23 12:34:32 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

6803402: Race condition in AbstractQueuedSynchronizer

Browse source 
Read fields in reverse initialization order

Reviewed-by: martin
This commit is contained in:
Doug Lea 2009-02-24 14:01:45 -08:00
parent ee5c2301ec
commit ca6e1aecc3
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
jdk/src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java
View file

@ -1222,8 +1222,10 @@ public abstract class AbstractQueuedLongSynchronizer
// The correctness of this depends on head being initialized
// before tail and on head.next being accurate if the current
// thread is first in queue.
Node h, s;
return (h = head) != tail &&
Node t = tail; // Read fields in reverse initialization order
Node h = head;
Node s;
return h != t &&
((s = h.next) == null || s.thread != Thread.currentThread());
}

6
jdk/src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java
View file

@ -1445,8 +1445,10 @@ public abstract class AbstractQueuedSynchronizer
// The correctness of this depends on head being initialized
// before tail and on head.next being accurate if the current
// thread is first in queue.
Node h, s;
return (h = head) != tail &&
Node t = tail; // Read fields in reverse initialization order
Node h = head;
Node s;
return h != t &&
((s = h.next) == null || s.thread != Thread.currentThread());
}