archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 23:04:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8219579: Remove redundant signature parsing from the verifier

Browse source 
Change verifier signature checking into asserts because ClassFileParser checks signatures for files being verified.

Reviewed-by: lfoltan, coleenp, redestad, dholmes
This commit is contained in:
Harold Seigel 2019-03-14 09:38:17 -04:00
parent 77832350f1
commit cace9d1c8e
6 changed files with 520 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/hotspot/share/runtime/signature.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -418,18 +418,7 @@ int SignatureStream::reference_parameter_count() {
return args_count;
}
bool SignatureVerifier::is_valid_signature(Symbol* sig) {
const char* signature = (const char*)sig->bytes();
ssize_t len = sig->utf8_length();
if (signature == NULL || signature[0] == '\0' || len < 1) {
return false;
} else if (signature[0] == '(') {
return is_valid_method_signature(sig);
} else {
return is_valid_type_signature(sig);
}
}
#ifdef ASSERT
bool SignatureVerifier::is_valid_method_signature(Symbol* sig) {
const char* method_sig = (const char*)sig->bytes();
ssize_t len = sig->utf8_length();
@ -499,3 +488,4 @@ bool SignatureVerifier::invalid_name_char(char c) {
return false;
}
}
#endif // ASSERT