archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-22 20:14:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8024352: MBeanOperationInfo accepts any int value as "impact"

Browse source 
MBeanOperationInfo throw an llegalArgumentException if the impact argument is not among the defined values

Reviewed-by: rriggs, dfuchs, mchung
This commit is contained in:
Ujwal Vangapally 2017-11-17 11:08:44 +05:30 • committed by Ujwal Vangapally
parent eadfc06bd0
commit d207240545
3 changed files with 104 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/java.management/share/classes/javax/management/MBeanOperationInfo.java
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -146,6 +146,9 @@ public class MBeanOperationInfo extends MBeanFeatureInfo implements Cloneable {
* @param descriptor The descriptor for the operation. This may be null
* which is equivalent to an empty descriptor.
*
* @throws IllegalArgumentException if {@code impact} is not one of
* {@linkplain #ACTION}, {@linkplain #ACTION_INFO}, {@linkplain #INFO} or {@linkplain #UNKNOWN}.
*
* @since 1.6
*/
public MBeanOperationInfo(String name,
@ -157,6 +160,12 @@ public class MBeanOperationInfo extends MBeanFeatureInfo implements Cloneable {
super(name, description, descriptor);
if (impact < INFO || impact > UNKNOWN) {
throw new IllegalArgumentException("Argument impact can only be "
+ "one of ACTION, ACTION_INFO, "
+ "INFO, or UNKNOWN" + " given value is :" + impact);
}
if (signature == null || signature.length == 0)
signature = MBeanParameterInfo.NO_PARAMS;
else
@ -259,8 +268,7 @@ public class MBeanOperationInfo extends MBeanFeatureInfo implements Cloneable {
case ACTION: impactString = "action"; break;
case ACTION_INFO: impactString = "action/info"; break;
case INFO: impactString = "info"; break;
case UNKNOWN: impactString = "unknown"; break;
default: impactString = "(" + getImpact() + ")";
default: impactString = "unknown";
}
return getClass().getName() + "[" +
"description=" + getDescription() + ", " +