archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-26 06:14:49 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8029343: CodeCache::allocate increments '_number_of_blobs' even if allocation fails

Browse source 
Incrementing the number of code blobs in CodeCache::allocate(...) is now only performed if allocation succeeds. The guarantee is fixed.

Reviewed-by: kvn, iveresov
This commit is contained in:
Tobias Hartmann 2014-05-09 09:12:39 +02:00 • committed by Albert Noll
parent 013509580f
commit d2af4e35ec
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
hotspot/src/share/vm/code/codeCache.cpp
View file

@ -178,10 +178,12 @@ CodeBlob* CodeCache::allocate(int size, bool is_critical) {
// cache will contain a garbage CodeBlob until the caller can
// run the constructor for the CodeBlob subclass he is busy
// instantiating.
guarantee(size >= 0, "allocation request must be reasonable");
assert_locked_or_safepoint(CodeCache_lock);
assert(size > 0, "allocation request must be reasonable");
if (size <= 0) {
return NULL;
}
CodeBlob* cb = NULL;
_number_of_blobs++;
while (true) {
cb = (CodeBlob*)_heap->allocate(size, is_critical);
if (cb != NULL) break;
@ -199,6 +201,7 @@ CodeBlob* CodeCache::allocate(int size, bool is_critical) {
maxCodeCacheUsed = MAX2(maxCodeCacheUsed, ((address)_heap->high_boundary() -
(address)_heap->low_boundary()) - unallocated_capacity());
print_trace("allocation", cb, size);
_number_of_blobs++;
return cb;
}