From d3534b08b5691c362db987f207da7cdd9c3b4b5a Mon Sep 17 00:00:00 2001
From: Brian Burkhalter <bpb@openjdk.org>
Date: Mon, 30 Oct 2023 18:28:01 +0000
Subject: [PATCH] 8318677: (ch) Add implNote about minBufferCap to main variant
 of Channels.newWriter

Reviewed-by: alanb, rriggs
---
 src/java.base/share/classes/java/nio/channels/Channels.java | 6 +++++-
 test/jdk/java/nio/channels/Channels/NewWriter.java          | 3 +--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/java.base/share/classes/java/nio/channels/Channels.java b/src/java.base/share/classes/java/nio/channels/Channels.java
index af3c6bdff73..fb113938d1d 100644
--- a/src/java.base/share/classes/java/nio/channels/Channels.java
+++ b/src/java.base/share/classes/java/nio/channels/Channels.java
@@ -523,6 +523,9 @@ public final class Channels {
      * The resulting stream will not otherwise be buffered.  Closing the stream
      * will in turn cause the channel to be closed.  </p>
      *
+     * @implNote
+     * The value of {@code minBufferCap} is ignored.
+     *
      * @param  ch
      *         The channel to which bytes will be written
      *
@@ -532,7 +535,8 @@ public final class Channels {
      * @param  minBufferCap
      *         The minimum capacity of the internal byte buffer,
      *         or {@code -1} if an implementation-dependent
-     *         default capacity is to be used
+     *         default capacity is to be used. The value of
+     *         {@code minBufferCap} may be ignored
      *
      * @return  A new writer
      */
diff --git a/test/jdk/java/nio/channels/Channels/NewWriter.java b/test/jdk/java/nio/channels/Channels/NewWriter.java
index 95445f0b84a..a1a8e2d7a13 100644
--- a/test/jdk/java/nio/channels/Channels/NewWriter.java
+++ b/test/jdk/java/nio/channels/Channels/NewWriter.java
@@ -51,7 +51,7 @@ public class NewWriter {
     private int actual = 0;
 
     @Test
-    public void oneByteChannel() throws IOException {
+    public void customWritableByteChannel() throws IOException {
         try (Writer writer = Channels.newWriter(new WritableByteChannel() {
             @Override
             public int write(ByteBuffer src) {
@@ -89,7 +89,6 @@ public class NewWriter {
                 ss.bind(new InetSocketAddress(lb, 0));
                 sc.connect(ss.getLocalSocketAddress());
                 sc.configureBlocking(false);
-                sc.setOption(StandardSocketOptions.SO_SNDBUF, 8192);
                 try (Writer writer = Channels.newWriter(sc,
                     StandardCharsets.UTF_8)) {
                     for (int i = 1; i < Integer.MAX_VALUE; i++) {