archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 23:04:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8212202: [Windows] Exception if no printers are installed

Browse source 
Reviewed-by: prr
This commit is contained in:
Shashidhara Veerabhadraiah 2019-02-25 11:02:53 +05:30
parent c373740319
commit d644970c02
3 changed files with 45 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
View file

@ -403,18 +403,36 @@ public class PrintServiceLookupProvider extends PrintServiceLookup {
list.
*/
class RemotePrinterChangeListener implements Runnable {
private String[] prevRemotePrinters;
private String[] prevRemotePrinters = null;
RemotePrinterChangeListener() {
prevRemotePrinters = getRemotePrintersNames();
}
boolean doCompare(String[] str1, String[] str2) {
if (str1 == null && str2 == null) {
return false;
} else if (str1 == null || str2 == null) {
return true;
}
if (str1.length != str2.length) {
return true;
} else {
for (int i = 0;i < str1.length;i++) {
for (int j = 0;j < str2.length;j++) {
// skip if both are nulls
if (str1[i] == null && str2[j] == null) {
continue;
}
// return true if there is a 'difference' but
// no need to access the individual string
if (str1[i] == null || str2[j] == null) {
return true;
}
// do comparison only if they are non-nulls
if (!str1[i].equals(str2[j])) {
return true;
}
@ -428,15 +446,19 @@ public class PrintServiceLookupProvider extends PrintServiceLookup {
@Override
public void run() {
while (true) {
String[] currentRemotePrinters = getRemotePrintersNames();
if (doCompare(prevRemotePrinters, currentRemotePrinters)) {
if (prevRemotePrinters != null && prevRemotePrinters.length > 0) {
String[] currentRemotePrinters = getRemotePrintersNames();
if (doCompare(prevRemotePrinters, currentRemotePrinters)) {
// updated the printers data
// printers list now contains both local and network printer data
refreshServices();
// updated the printers data
// printers list now contains both local and network printer data
refreshServices();
// store the current data for next comparison
prevRemotePrinters = currentRemotePrinters;
// store the current data for next comparison
prevRemotePrinters = currentRemotePrinters;
}
} else {
prevRemotePrinters = getRemotePrintersNames();
}
try {