8212595: Remove unused size_helper() in oop_oop_iterate* in instanceKlass.inline.hpp

Reviewed-by: shade, pliden
This commit is contained in:
Leo Korinth 2018-10-18 11:23:54 +02:00
parent 3c2c6bce02
commit d75f70d91c
2 changed files with 6 additions and 12 deletions

View file

@ -1195,7 +1195,7 @@ public:
// Iterate over all oop fields and metadata. // Iterate over all oop fields and metadata.
template <typename T, class OopClosureType> template <typename T, class OopClosureType>
inline int oop_oop_iterate(oop obj, OopClosureType* closure); inline void oop_oop_iterate(oop obj, OopClosureType* closure);
// Iterate over all oop fields in one oop map. // Iterate over all oop fields in one oop map.
template <typename T, class OopClosureType> template <typename T, class OopClosureType>
@ -1205,7 +1205,7 @@ public:
// Reverse iteration // Reverse iteration
// Iterate over all oop fields and metadata. // Iterate over all oop fields and metadata.
template <typename T, class OopClosureType> template <typename T, class OopClosureType>
inline int oop_oop_iterate_reverse(oop obj, OopClosureType* closure); inline void oop_oop_iterate_reverse(oop obj, OopClosureType* closure);
private: private:
// Iterate over all oop fields in the oop maps. // Iterate over all oop fields in the oop maps.
@ -1225,7 +1225,7 @@ public:
// Iterate over all oop fields and metadata. // Iterate over all oop fields and metadata.
template <typename T, class OopClosureType> template <typename T, class OopClosureType>
inline int oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr); inline void oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr);
private: private:
// Iterate over all oop fields in one oop map. // Iterate over all oop fields in one oop map.

View file

@ -130,28 +130,24 @@ ALWAYSINLINE void InstanceKlass::oop_oop_iterate_oop_maps_bounded(oop obj, OopCl
} }
template <typename T, class OopClosureType> template <typename T, class OopClosureType>
ALWAYSINLINE int InstanceKlass::oop_oop_iterate(oop obj, OopClosureType* closure) { ALWAYSINLINE void InstanceKlass::oop_oop_iterate(oop obj, OopClosureType* closure) {
if (Devirtualizer::do_metadata(closure)) { if (Devirtualizer::do_metadata(closure)) {
Devirtualizer::do_klass(closure, this); Devirtualizer::do_klass(closure, this);
} }
oop_oop_iterate_oop_maps<T>(obj, closure); oop_oop_iterate_oop_maps<T>(obj, closure);
return size_helper();
} }
template <typename T, class OopClosureType> template <typename T, class OopClosureType>
ALWAYSINLINE int InstanceKlass::oop_oop_iterate_reverse(oop obj, OopClosureType* closure) { ALWAYSINLINE void InstanceKlass::oop_oop_iterate_reverse(oop obj, OopClosureType* closure) {
assert(!Devirtualizer::do_metadata(closure), assert(!Devirtualizer::do_metadata(closure),
"Code to handle metadata is not implemented"); "Code to handle metadata is not implemented");
oop_oop_iterate_oop_maps_reverse<T>(obj, closure); oop_oop_iterate_oop_maps_reverse<T>(obj, closure);
return size_helper();
} }
template <typename T, class OopClosureType> template <typename T, class OopClosureType>
ALWAYSINLINE int InstanceKlass::oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr) { ALWAYSINLINE void InstanceKlass::oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr) {
if (Devirtualizer::do_metadata(closure)) { if (Devirtualizer::do_metadata(closure)) {
if (mr.contains(obj)) { if (mr.contains(obj)) {
Devirtualizer::do_klass(closure, this); Devirtualizer::do_klass(closure, this);
@ -159,8 +155,6 @@ ALWAYSINLINE int InstanceKlass::oop_oop_iterate_bounded(oop obj, OopClosureType*
} }
oop_oop_iterate_oop_maps_bounded<T>(obj, closure, mr); oop_oop_iterate_oop_maps_bounded<T>(obj, closure, mr);
return size_helper();
} }
#endif // SHARE_VM_OOPS_INSTANCEKLASS_INLINE_HPP #endif // SHARE_VM_OOPS_INSTANCEKLASS_INLINE_HPP