archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-16 17:14:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8214144: Remove confusing locking_enqueue_completed_buffer

Browse source 
Remove function.

Reviewed-by: tschatzl, manc
This commit is contained in:
Kim Barrett 2018-11-21 09:40:19 -05:00
parent a4fb817366
commit d8e5d52deb
2 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/hotspot/share/gc/shared/ptrQueue.cpp
View file

@ -74,12 +74,6 @@ void PtrQueue::enqueue_known_active(void* ptr) {
_buf[index()] = ptr; _buf[index()] = ptr;
} }
void PtrQueue::locking_enqueue_completed_buffer(BufferNode* node) {
assert(_lock->owned_by_self(), "Required.");
qset()->enqueue_complete_buffer(node);
}
BufferNode* BufferNode::allocate(size_t size) { BufferNode* BufferNode::allocate(size_t size) {
size_t byte_size = size * sizeof(void*); size_t byte_size = size * sizeof(void*);
void* data = NEW_C_HEAP_ARRAY(char, buffer_offset() + byte_size, mtGC); void* data = NEW_C_HEAP_ARRAY(char, buffer_offset() + byte_size, mtGC);
@ -222,7 +216,7 @@ void PtrQueue::handle_zero_index() {
BufferNode* node = BufferNode::make_node_from_buffer(_buf, index()); BufferNode* node = BufferNode::make_node_from_buffer(_buf, index());
_buf = NULL; // clear shared _buf field _buf = NULL; // clear shared _buf field
locking_enqueue_completed_buffer(node); // enqueue completed buffer qset()->enqueue_complete_buffer(node);
assert(_buf == NULL, "multiple enqueuers appear to be racing"); assert(_buf == NULL, "multiple enqueuers appear to be racing");
} else { } else {
BufferNode* node = BufferNode::make_node_from_buffer(_buf, index()); BufferNode* node = BufferNode::make_node_from_buffer(_buf, index());

1
src/hotspot/share/gc/shared/ptrQueue.hpp
View file

@ -154,7 +154,6 @@ public:
// get into an infinite loop). // get into an infinite loop).
virtual bool should_enqueue_buffer() { return true; } virtual bool should_enqueue_buffer() { return true; }
void handle_zero_index(); void handle_zero_index();
void locking_enqueue_completed_buffer(BufferNode* node);
void enqueue_known_active(void* ptr); void enqueue_known_active(void* ptr);