archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-28 15:24:43 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

6667618: disable LoadL->ConvL2I ==> LoadI optimization

Browse source 
This optimization causes problems (sizes of Load and Store nodes do not match) for objects initialization code and Escape Analysis

Reviewed-by: jrose, never
This commit is contained in:
Vladimir Kozlov 2008-02-29 19:57:41 -08:00
parent 09d7f4bbcf
commit dc6ad19d70
2 changed files with 10 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

20
hotspot/src/share/vm/opto/memnode.cpp
View file

@ -108,19 +108,13 @@ Node *MemNode::Ideal_common(PhaseGVN *phase, bool can_reshape) {
// Avoid independent memory operations
Node* old_mem = mem;
if (mem->is_Proj() && mem->in(0)->is_Initialize()) {
InitializeNode* init = mem->in(0)->as_Initialize();
if (init->is_complete()) { // i.e., after macro expansion
const TypePtr* tp = t_adr->is_ptr();
uint alias_idx = phase->C->get_alias_index(tp);
// Free this slice from the init. It was hooked, temporarily,
// by GraphKit::set_output_for_allocation.
if (alias_idx > Compile::AliasIdxRaw) {
mem = init->memory(alias_idx);
// ...but not with the raw-pointer slice.
}
}
}
// The code which unhooks non-raw memories from complete (macro-expanded)
// initializations was removed. After macro-expansion all stores catched
// by Initialize node became raw stores and there is no information
// which memory slices they modify. So it is unsafe to move any memory
// operation above these stores. Also in most cases hooked non-raw memories
// were already unhooked by using information from detect_ptr_independence()
// and find_previous_store().
if (mem->is_MergeMem()) {
MergeMemNode* mmem = mem->as_MergeMem();