archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8322512: StringBuffer.repeat does not work correctly after toString() was called

Browse source 
Reviewed-by: rriggs, jpai
This commit is contained in:
Jim Laskey 2024-01-04 12:46:31 +00:00
parent c3cd1f1814
commit df22fb322e
2 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/java.base/share/classes/java/lang/StringBuffer.java
View file

@ -715,6 +715,7 @@ import jdk.internal.vm.annotation.IntrinsicCandidate;
*/ */
@Override @Override
public synchronized StringBuffer repeat(int codePoint, int count) { public synchronized StringBuffer repeat(int codePoint, int count) {
toStringCache = null;
super.repeat(codePoint, count); super.repeat(codePoint, count);
return this; return this;
} }
@ -726,6 +727,7 @@ import jdk.internal.vm.annotation.IntrinsicCandidate;
*/ */
@Override @Override
public synchronized StringBuffer repeat(CharSequence cs, int count) { public synchronized StringBuffer repeat(CharSequence cs, int count) {
toStringCache = null;
super.repeat(cs, count); super.repeat(cs, count);
return this; return this;
} }

15
test/jdk/java/lang/StringBuilder/StringBufferRepeat.java
View file

@ -29,7 +29,7 @@ import java.util.Arrays;
/** /**
* @test * @test
* @bug 8302323 * @bug 8302323 8322512
* @summary Test StringBuffer.repeat sanity tests * @summary Test StringBuffer.repeat sanity tests
* @run testng/othervm -XX:-CompactStrings StringBufferRepeat * @run testng/othervm -XX:-CompactStrings StringBufferRepeat
* @run testng/othervm -XX:+CompactStrings StringBufferRepeat * @run testng/othervm -XX:+CompactStrings StringBufferRepeat
@ -129,6 +129,19 @@ public class StringBufferRepeat {
expected = "\u0000\u0000\u0000\u0000\u0000\u0000\u0020\u0020\u0020\u0020\u0020\u0020\u2461\u2462\u2462\u2462\u2462\u2462\udbff\udfff\udbff\udfff\udbff\udfff\udbff\udfff\udbff\udfff\udbff\udfff"; expected = "\u0000\u0000\u0000\u0000\u0000\u0000\u0020\u0020\u0020\u0020\u0020\u0020\u2461\u2462\u2462\u2462\u2462\u2462\udbff\udfff\udbff\udfff\udbff\udfff\udbff\udfff\udbff\udfff\udbff\udfff";
assertEquals(expected, sb.toString()); assertEquals(expected, sb.toString());
// toStringCache
sb.setLength(0);
sb.toString();
sb.repeat('*', 5);
expected = "*****";
assertEquals(sb.toString(), expected);
sb.setLength(0);
sb.toString();
sb.repeat("*", 5);
assertEquals(sb.toString(), expected);
} }
public void exceptions() { public void exceptions() {