archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 06:45:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8199124: (fs) Reduce allocation for file system methods that are invoked with no open options

Browse source 
Reviewed-by: alanb
This commit is contained in:
Michael Skells 2018-06-21 11:10:55 -07:00 • committed by Brian Burkhalter
parent 91d9f3fbe0
commit df509b1b16
4 changed files with 36 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/java.base/share/classes/java/nio/file/Files.java
View file

@ -410,8 +410,13 @@ public final class Files {
public static SeekableByteChannel newByteChannel(Path path, OpenOption... options)
throws IOException
{
Set<OpenOption> set = new HashSet<>(options.length);
Collections.addAll(set, options);
Set<OpenOption> set;
if (options.length == 0) {
set = Collections.emptySet();
} else {
set = new HashSet<>();
Collections.addAll(set, options);
}
return newByteChannel(path, set);
}
@ -599,6 +604,9 @@ public final class Files {
// -- Creation and deletion --
private static final Set<OpenOption> DEFAULT_CREATE_OPTIONS =
Set.of(StandardOpenOption.CREATE_NEW, StandardOpenOption.WRITE);
/**
* Creates a new and empty file, failing if the file already exists. The
* check for the existence of the file and the creation of the new file if
@ -635,9 +643,7 @@ public final class Files {
public static Path createFile(Path path, FileAttribute<?>... attrs)
throws IOException
{
EnumSet<StandardOpenOption> options =
EnumSet.<StandardOpenOption>of(StandardOpenOption.CREATE_NEW, StandardOpenOption.WRITE);
newByteChannel(path, options, attrs).close();
newByteChannel(path, DEFAULT_CREATE_OPTIONS, attrs).close();
return path;
}