archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-25 22:04:51 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

6704010: Internal Error (src/share/vm/interpreter/interpreterRuntime.cpp:1106)

Browse source 
Fixed a race condition in the assertion caused by an unguarded, concurrent access to a GrowableArray object.

Reviewed-by: coleenp, dholmes, dsamersoff
This commit is contained in:
Volker Simonis 2010-12-04 00:09:05 -05:00 • committed by Coleen Phillimore
parent 7765368022
commit df6c2c2e63
1 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
hotspot/src/share/vm/interpreter/interpreterRuntime.cpp
View file

@ -1193,9 +1193,20 @@ void SignatureHandlerLibrary::add(methodHandle method) {
method->set_signature_handler(_handlers->at(handler_index));
}
}
#ifdef ASSERT
int handler_index, fingerprint_index;
{
// '_handlers' and '_fingerprints' are 'GrowableArray's and are NOT synchronized
// in any way if accessed from multiple threads. To avoid races with another
// thread which may change the arrays in the above, mutex protected block, we
// have to protect this read access here with the same mutex as well!
MutexLocker mu(SignatureHandlerLibrary_lock);
handler_index = _handlers->find(method->signature_handler());
fingerprint_index = _fingerprints->find(Fingerprinter(method).fingerprint());
}
assert(method->signature_handler() == Interpreter::slow_signature_handler() ||
_handlers->find(method->signature_handler()) == _fingerprints->find(Fingerprinter(method).fingerprint()),
"sanity check");
handler_index == fingerprint_index, "sanity check");
#endif
}