8057107: cleanup indent white space issues prior to Contended Locking reorder and cache line bucket

Reviewed-by: fparain, sspitsyn, coleenp
This commit is contained in:
Daniel D. Daugherty 2014-09-10 11:48:20 -06:00
parent 2ad3d66d79
commit e1a36d62a0
15 changed files with 3764 additions and 3764 deletions

View file

@ -3670,12 +3670,12 @@ void os::SuspendedThreadTask::internal_do_task() {
/// ///
class PcFetcher : public os::SuspendedThreadTask { class PcFetcher : public os::SuspendedThreadTask {
public: public:
PcFetcher(Thread* thread) : os::SuspendedThreadTask(thread) {} PcFetcher(Thread* thread) : os::SuspendedThreadTask(thread) {}
ExtendedPC result(); ExtendedPC result();
protected: protected:
void do_task(const os::SuspendedThreadTaskContext& context); void do_task(const os::SuspendedThreadTaskContext& context);
private: private:
ExtendedPC _epc; ExtendedPC _epc;
}; };

View file

@ -147,7 +147,7 @@ class Bsd {
// BsdThreads work-around for 6292965 // BsdThreads work-around for 6292965
static int safe_cond_timedwait(pthread_cond_t *_cond, pthread_mutex_t *_mutex, const struct timespec *_abstime); static int safe_cond_timedwait(pthread_cond_t *_cond, pthread_mutex_t *_mutex, const struct timespec *_abstime);
private: private:
typedef int (*sched_getcpu_func_t)(void); typedef int (*sched_getcpu_func_t)(void);
typedef int (*numa_node_to_cpus_func_t)(int node, unsigned long *buffer, int bufferlen); typedef int (*numa_node_to_cpus_func_t)(int node, unsigned long *buffer, int bufferlen);
typedef int (*numa_max_node_func_t)(void); typedef int (*numa_max_node_func_t)(void);
@ -170,7 +170,7 @@ private:
static void set_numa_tonode_memory(numa_tonode_memory_func_t func) { _numa_tonode_memory = func; } static void set_numa_tonode_memory(numa_tonode_memory_func_t func) { _numa_tonode_memory = func; }
static void set_numa_interleave_memory(numa_interleave_memory_func_t func) { _numa_interleave_memory = func; } static void set_numa_interleave_memory(numa_interleave_memory_func_t func) { _numa_interleave_memory = func; }
static void set_numa_all_nodes(unsigned long* ptr) { _numa_all_nodes = ptr; } static void set_numa_all_nodes(unsigned long* ptr) { _numa_all_nodes = ptr; }
public: public:
static int sched_getcpu() { return _sched_getcpu != NULL ? _sched_getcpu() : -1; } static int sched_getcpu() { return _sched_getcpu != NULL ? _sched_getcpu() : -1; }
static int numa_node_to_cpus(int node, unsigned long *buffer, int bufferlen) { static int numa_node_to_cpus(int node, unsigned long *buffer, int bufferlen) {
return _numa_node_to_cpus != NULL ? _numa_node_to_cpus(node, buffer, bufferlen) : -1; return _numa_node_to_cpus != NULL ? _numa_node_to_cpus(node, buffer, bufferlen) : -1;

View file

@ -1788,9 +1788,9 @@ bool os::dll_address_to_library_name(address addr, char* buf,
return false; return false;
} }
// Loads .dll/.so and // Loads .dll/.so and
// in case of error it checks if .dll/.so was built for the // in case of error it checks if .dll/.so was built for the
// same architecture as Hotspot is running on // same architecture as Hotspot is running on
// Remember the stack's state. The Linux dynamic linker will change // Remember the stack's state. The Linux dynamic linker will change
@ -4865,12 +4865,12 @@ void os::SuspendedThreadTask::internal_do_task() {
} }
class PcFetcher : public os::SuspendedThreadTask { class PcFetcher : public os::SuspendedThreadTask {
public: public:
PcFetcher(Thread* thread) : os::SuspendedThreadTask(thread) {} PcFetcher(Thread* thread) : os::SuspendedThreadTask(thread) {}
ExtendedPC result(); ExtendedPC result();
protected: protected:
void do_task(const os::SuspendedThreadTaskContext& context); void do_task(const os::SuspendedThreadTaskContext& context);
private: private:
ExtendedPC _epc; ExtendedPC _epc;
}; };

View file

@ -235,7 +235,7 @@ class Linux {
// LinuxThreads work-around for 6292965 // LinuxThreads work-around for 6292965
static int safe_cond_timedwait(pthread_cond_t *_cond, pthread_mutex_t *_mutex, const struct timespec *_abstime); static int safe_cond_timedwait(pthread_cond_t *_cond, pthread_mutex_t *_mutex, const struct timespec *_abstime);
private: private:
typedef int (*sched_getcpu_func_t)(void); typedef int (*sched_getcpu_func_t)(void);
typedef int (*numa_node_to_cpus_func_t)(int node, unsigned long *buffer, int bufferlen); typedef int (*numa_node_to_cpus_func_t)(int node, unsigned long *buffer, int bufferlen);
typedef int (*numa_max_node_func_t)(void); typedef int (*numa_max_node_func_t)(void);
@ -262,7 +262,7 @@ private:
static void set_numa_set_bind_policy(numa_set_bind_policy_func_t func) { _numa_set_bind_policy = func; } static void set_numa_set_bind_policy(numa_set_bind_policy_func_t func) { _numa_set_bind_policy = func; }
static void set_numa_all_nodes(unsigned long* ptr) { _numa_all_nodes = ptr; } static void set_numa_all_nodes(unsigned long* ptr) { _numa_all_nodes = ptr; }
static int sched_getcpu_syscall(void); static int sched_getcpu_syscall(void);
public: public:
static int sched_getcpu() { return _sched_getcpu != NULL ? _sched_getcpu() : -1; } static int sched_getcpu() { return _sched_getcpu != NULL ? _sched_getcpu() : -1; }
static int numa_node_to_cpus(int node, unsigned long *buffer, int bufferlen) { static int numa_node_to_cpus(int node, unsigned long *buffer, int bufferlen) {
return _numa_node_to_cpus != NULL ? _numa_node_to_cpus(node, buffer, bufferlen) : -1; return _numa_node_to_cpus != NULL ? _numa_node_to_cpus(node, buffer, bufferlen) : -1;

View file

@ -332,7 +332,7 @@ void os::Solaris::try_enable_extended_io() {
static int _processors_online = 0; static int _processors_online = 0;
jint os::Solaris::_os_thread_limit = 0; jint os::Solaris::_os_thread_limit = 0;
volatile jint os::Solaris::_os_thread_count = 0; volatile jint os::Solaris::_os_thread_count = 0;
julong os::available_memory() { julong os::available_memory() {
@ -1338,7 +1338,7 @@ void os::free_thread_local_storage(int index) {
} }
#define SMALLINT 32 // libthread allocate for tsd_common is a version specific #define SMALLINT 32 // libthread allocate for tsd_common is a version specific
// small number - point is NO swap space available // small number - point is NO swap space available
void os::thread_local_storage_at_put(int index, void* value) { void os::thread_local_storage_at_put(int index, void* value) {
// %%% this is used only in threadLocalStorage.cpp // %%% this is used only in threadLocalStorage.cpp
if (thr_setspecific((thread_key_t)index, value)) { if (thr_setspecific((thread_key_t)index, value)) {
@ -1759,9 +1759,9 @@ void os::print_dll_info(outputStream * st) {
dlclose(handle); dlclose(handle);
} }
// Loads .dll/.so and // Loads .dll/.so and
// in case of error it checks if .dll/.so was built for the // in case of error it checks if .dll/.so was built for the
// same architecture as Hotspot is running on // same architecture as Hotspot is running on
void * os::dll_load(const char *filename, char *ebuf, int ebuflen) void * os::dll_load(const char *filename, char *ebuf, int ebuflen)
{ {
@ -3830,12 +3830,12 @@ void os::SuspendedThreadTask::internal_do_task() {
} }
class PcFetcher : public os::SuspendedThreadTask { class PcFetcher : public os::SuspendedThreadTask {
public: public:
PcFetcher(Thread* thread) : os::SuspendedThreadTask(thread) {} PcFetcher(Thread* thread) : os::SuspendedThreadTask(thread) {}
ExtendedPC result(); ExtendedPC result();
protected: protected:
void do_task(const os::SuspendedThreadTaskContext& context); void do_task(const os::SuspendedThreadTaskContext& context);
private: private:
ExtendedPC _epc; ExtendedPC _epc;
}; };
@ -5956,7 +5956,7 @@ int os::connect(int fd, struct sockaddr *him, socklen_t len) {
} }
} }
return _result; return _result;
} }
int os::accept(int fd, struct sockaddr* him, socklen_t* len) { int os::accept(int fd, struct sockaddr* him, socklen_t* len) {
if (fd < 0) { if (fd < 0) {

View file

@ -2763,7 +2763,7 @@ static HANDLE _hToken;
// Container for NUMA node list info // Container for NUMA node list info
class NUMANodeListHolder { class NUMANodeListHolder {
private: private:
int *_numa_used_node_list; // allocated below int *_numa_used_node_list; // allocated below
int _numa_used_node_count; int _numa_used_node_count;
@ -2773,7 +2773,7 @@ private:
} }
} }
public: public:
NUMANodeListHolder() { NUMANodeListHolder() {
_numa_used_node_count = 0; _numa_used_node_count = 0;
_numa_used_node_list = NULL; _numa_used_node_list = NULL;
@ -3436,9 +3436,9 @@ class HighResolutionInterval : public CHeapObj<mtThread> {
// to decreased efficiency related to increased timer "tick" rates. We want to minimize // to decreased efficiency related to increased timer "tick" rates. We want to minimize
// (a) calls to timeBeginPeriod() and timeEndPeriod() and (b) time spent with high // (a) calls to timeBeginPeriod() and timeEndPeriod() and (b) time spent with high
// resolution timers running. // resolution timers running.
private: private:
jlong resolution; jlong resolution;
public: public:
HighResolutionInterval(jlong ms) { HighResolutionInterval(jlong ms) {
resolution = ms % 10L; resolution = ms % 10L;
if (resolution != 0) { if (resolution != 0) {
@ -3684,7 +3684,7 @@ int os::win32::_processor_level = 0;
julong os::win32::_physical_memory = 0; julong os::win32::_physical_memory = 0;
size_t os::win32::_default_stack_size = 0; size_t os::win32::_default_stack_size = 0;
intx os::win32::_os_thread_limit = 0; intx os::win32::_os_thread_limit = 0;
volatile intx os::win32::_os_thread_count = 0; volatile intx os::win32::_os_thread_count = 0;
bool os::win32::_is_nt = false; bool os::win32::_is_nt = false;
@ -5328,7 +5328,7 @@ inline BOOL os::Kernel32Dll::SwitchToThreadAvailable() {
return true; return true;
} }
// Help tools // Help tools
inline BOOL os::Kernel32Dll::HelpToolsAvailable() { inline BOOL os::Kernel32Dll::HelpToolsAvailable() {
return true; return true;
} }

View file

@ -45,7 +45,7 @@
#include "utilities/preserveException.hpp" #include "utilities/preserveException.hpp"
#if defined(__GNUC__) && !defined(IA64) && !defined(PPC64) #if defined(__GNUC__) && !defined(IA64) && !defined(PPC64)
// Need to inhibit inlining for older versions of GCC to avoid build-time failures // Need to inhibit inlining for older versions of GCC to avoid build-time failures
#define NOINLINE __attribute__((noinline)) #define NOINLINE __attribute__((noinline))
#else #else
#define NOINLINE #define NOINLINE

View file

@ -163,7 +163,7 @@ class ObjectMonitor {
// _count == 0 _EntryList == NULL etc // _count == 0 _EntryList == NULL etc
} }
private: private:
void Recycle() { void Recycle() {
// TODO: add stronger asserts ... // TODO: add stronger asserts ...
// _cxq == 0 _succ == NULL _owner == NULL _waiters == 0 // _cxq == 0 _succ == NULL _owner == NULL _waiters == 0
@ -180,7 +180,7 @@ private:
OwnerIsThread = 0; OwnerIsThread = 0;
} }
public: public:
void* object() const; void* object() const;
void* object_addr(); void* object_addr();

View file

@ -43,7 +43,7 @@
#include "utilities/preserveException.hpp" #include "utilities/preserveException.hpp"
#if defined(__GNUC__) && !defined(PPC64) #if defined(__GNUC__) && !defined(PPC64)
// Need to inhibit inlining for older versions of GCC to avoid build-time failures // Need to inhibit inlining for older versions of GCC to avoid build-time failures
#define NOINLINE __attribute__((noinline)) #define NOINLINE __attribute__((noinline))
#else #else
#define NOINLINE #define NOINLINE
@ -1561,10 +1561,10 @@ void ObjectSynchronizer::deflate_idle_monitors() {
// Gives up on a particular monitor if an exception occurs, but continues // Gives up on a particular monitor if an exception occurs, but continues
// the overall iteration, swallowing the exception. // the overall iteration, swallowing the exception.
class ReleaseJavaMonitorsClosure: public MonitorClosure { class ReleaseJavaMonitorsClosure: public MonitorClosure {
private: private:
TRAPS; TRAPS;
public: public:
ReleaseJavaMonitorsClosure(Thread* thread) : THREAD(thread) {} ReleaseJavaMonitorsClosure(Thread* thread) : THREAD(thread) {}
void do_monitor(ObjectMonitor* mid) { void do_monitor(ObjectMonitor* mid) {
if (mid->owner() == THREAD) { if (mid->owner() == THREAD) {

View file

@ -2640,7 +2640,7 @@ void JavaThread::deoptimized_wrt_marked_nmethods() {
// the given JavaThread in its _processed_thread field. // the given JavaThread in its _processed_thread field.
class RememberProcessedThread: public StackObj { class RememberProcessedThread: public StackObj {
NamedThread* _cur_thr; NamedThread* _cur_thr;
public: public:
RememberProcessedThread(JavaThread* jthr) { RememberProcessedThread(JavaThread* jthr) {
Thread* thread = Thread::current(); Thread* thread = Thread::current();
if (thread->is_Named_thread()) { if (thread->is_Named_thread()) {

View file

@ -445,9 +445,9 @@ class Thread: public ThreadShadow {
virtual void oops_do(OopClosure* f, CLDClosure* cld_f, CodeBlobClosure* cf); virtual void oops_do(OopClosure* f, CLDClosure* cld_f, CodeBlobClosure* cf);
// Handles the parallel case for the method below. // Handles the parallel case for the method below.
private: private:
bool claim_oops_do_par_case(int collection_parity); bool claim_oops_do_par_case(int collection_parity);
public: public:
// Requires that "collection_parity" is that of the current roots // Requires that "collection_parity" is that of the current roots
// iteration. If "is_par" is false, sets the parity of "this" to // iteration. If "is_par" is false, sets the parity of "this" to
// "collection_parity", and returns "true". If "is_par" is true, // "collection_parity", and returns "true". If "is_par" is true,
@ -664,9 +664,9 @@ class NamedThread: public Thread {
// Worker threads are named and have an id of an assigned work. // Worker threads are named and have an id of an assigned work.
class WorkerThread: public NamedThread { class WorkerThread: public NamedThread {
private: private:
uint _id; uint _id;
public: public:
WorkerThread() : _id(0) { } WorkerThread() : _id(0) { }
virtual bool is_Worker_thread() const { return true; } virtual bool is_Worker_thread() const { return true; }
@ -1411,10 +1411,10 @@ class JavaThread: public Thread {
void print_on_error(outputStream* st, char* buf, int buflen) const; void print_on_error(outputStream* st, char* buf, int buflen) const;
void verify(); void verify();
const char* get_thread_name() const; const char* get_thread_name() const;
private: private:
// factor out low-level mechanics for use in both normal and error cases // factor out low-level mechanics for use in both normal and error cases
const char* get_thread_name_string(char* buf = NULL, int buflen = 0) const; const char* get_thread_name_string(char* buf = NULL, int buflen = 0) const;
public: public:
const char* get_threadgroup_name() const; const char* get_threadgroup_name() const;
const char* get_parent_name() const; const char* get_parent_name() const;
@ -1692,15 +1692,15 @@ public:
// JSR166 per-thread parker // JSR166 per-thread parker
private: private:
Parker* _parker; Parker* _parker;
public: public:
Parker* parker() { return _parker; } Parker* parker() { return _parker; }
// Biased locking support // Biased locking support
private: private:
GrowableArray<MonitorInfo*>* _cached_monitor_info; GrowableArray<MonitorInfo*>* _cached_monitor_info;
public: public:
GrowableArray<MonitorInfo*>* cached_monitor_info() { return _cached_monitor_info; } GrowableArray<MonitorInfo*>* cached_monitor_info() { return _cached_monitor_info; }
void set_cached_monitor_info(GrowableArray<MonitorInfo*>* info) { _cached_monitor_info = info; } void set_cached_monitor_info(GrowableArray<MonitorInfo*>* info) { _cached_monitor_info = info; }
@ -1708,12 +1708,12 @@ public:
bool is_attaching_via_jni() const { return _jni_attach_state == _attaching_via_jni; } bool is_attaching_via_jni() const { return _jni_attach_state == _attaching_via_jni; }
bool has_attached_via_jni() const { return is_attaching_via_jni() || _jni_attach_state == _attached_via_jni; } bool has_attached_via_jni() const { return is_attaching_via_jni() || _jni_attach_state == _attached_via_jni; }
inline void set_done_attaching_via_jni(); inline void set_done_attaching_via_jni();
private: private:
// This field is used to determine if a thread has claimed // This field is used to determine if a thread has claimed
// a par_id: it is UINT_MAX if the thread has not claimed a par_id; // a par_id: it is UINT_MAX if the thread has not claimed a par_id;
// otherwise its value is the par_id that has been claimed. // otherwise its value is the par_id that has been claimed.
uint _claimed_par_id; uint _claimed_par_id;
public: public:
uint get_claimed_par_id() { return _claimed_par_id; } uint get_claimed_par_id() { return _claimed_par_id; }
void set_claimed_par_id(uint id) { _claimed_par_id = id; } void set_claimed_par_id(uint id) { _claimed_par_id = id; }
}; };
@ -1782,9 +1782,9 @@ class CompilerThread : public JavaThread {
void oops_do(OopClosure* f, CLDClosure* cld_f, CodeBlobClosure* cf); void oops_do(OopClosure* f, CLDClosure* cld_f, CodeBlobClosure* cf);
#ifndef PRODUCT #ifndef PRODUCT
private: private:
IdealGraphPrinter *_ideal_graph_printer; IdealGraphPrinter *_ideal_graph_printer;
public: public:
IdealGraphPrinter *ideal_graph_printer() { return _ideal_graph_printer; } IdealGraphPrinter *ideal_graph_printer() { return _ideal_graph_printer; }
void set_ideal_graph_printer(IdealGraphPrinter *n) { _ideal_graph_printer = n; } void set_ideal_graph_printer(IdealGraphPrinter *n) { _ideal_graph_printer = n; }
#endif #endif
@ -1911,9 +1911,9 @@ class ThreadClosure: public StackObj {
}; };
class SignalHandlerMark: public StackObj { class SignalHandlerMark: public StackObj {
private: private:
Thread* _thread; Thread* _thread;
public: public:
SignalHandlerMark(Thread* t) { SignalHandlerMark(Thread* t) {
_thread = t; _thread = t;
if (_thread) _thread->enter_signal_handler(); if (_thread) _thread->enter_signal_handler();