archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-26 22:34:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8202685: Optimize ArrayList subList replaceAll

Browse source 
Reviewed-by: martin, psandoz, igerasim, redestad, dholmes, smarks, jrose, plevart
This commit is contained in:
Doug Lea 2018-05-22 21:46:51 -07:00
parent c9e23b5e71
commit e4046542ba
2 changed files with 58 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/java.base/share/classes/java/util/ArrayList.java
View file

@ -1221,6 +1221,10 @@ public class ArrayList<E> extends AbstractList<E>
return true;
}
public void replaceAll(UnaryOperator<E> operator) {
root.replaceAllRange(operator, offset, offset + size);
}
public boolean removeAll(Collection<?> c) {
return batchRemove(c, false);
}
@ -1724,15 +1728,18 @@ public class ArrayList<E> extends AbstractList<E>
@Override
public void replaceAll(UnaryOperator<E> operator) {
replaceAllRange(operator, 0, size);
modCount++;
}
private void replaceAllRange(UnaryOperator<E> operator, int i, int end) {
Objects.requireNonNull(operator);
final int expectedModCount = modCount;
final Object[] es = elementData;
final int size = this.size;
for (int i = 0; modCount == expectedModCount && i < size; i++)
for (; modCount == expectedModCount && i < end; i++)
es[i] = operator.apply(elementAt(es, i));
if (modCount != expectedModCount)
throw new ConcurrentModificationException();
modCount++;
}
@Override