archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-17 17:44:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8138667: java.lang.IllegalAccessError: tried to access method (for a protected method)

Browse source 
Reviewed-by: mcimadamore
This commit is contained in:
Srikanth Adayapalam 2016-09-13 19:32:03 +05:30
parent 7624e7608b
commit e4870c84e3
3 changed files with 118 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
View file

@ -2256,6 +2256,12 @@ public class LambdaToMethod extends TreeTranslator {
types.erasure(owner.enclClass().asType()));
}
boolean isProtectedInSuperClassOfEnclosingClassInOtherPackage() {
return ((tree.sym.flags() & PROTECTED) != 0 &&
tree.sym.packge() != owner.packge() &&
!owner.enclClass().isSubClass(tree.sym.owner, types));
}
/**
* Signature polymorphic methods need special handling.
* e.g. MethodHandle.invoke() MethodHandle.invokeExact()
@ -2293,6 +2299,7 @@ public class LambdaToMethod extends TreeTranslator {
needsVarArgsConversion() ||
isArrayOp() ||
isPrivateInOtherClass() ||
isProtectedInSuperClassOfEnclosingClassInOtherPackage() ||
!receiverAccessible() ||
(tree.getMode() == ReferenceMode.NEW &&
tree.kind != ReferenceKind.ARRAY_CTOR &&

71
langtools/test/tools/javac/lambda/methodReference/ProtectedInaccessibleMethodRefTest.java Normal file
View file

@ -0,0 +1,71 @@
/*
* Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8138667
* @summary Verify that javac emits suitable accessors when a method reference mentions a protected method that would need an accessor
* @run main ProtectedInaccessibleMethodRefTest
*/
import pack.SuperClass;
import java.util.concurrent.Callable;
public final class ProtectedInaccessibleMethodRefTest extends SuperClass {
static String message = "NOT OK";
public void doTest() throws Exception {
new Callable<Void>() {
@Override
public Void call() throws Exception {
final Runnable r = ProtectedInaccessibleMethodRefTest.this::myDo;
r.run();
return null;
}
}.call();
new Callable<Void>() {
@Override
public Void call() throws Exception {
final Runnable r = ProtectedInaccessibleMethodRefTest::myStaticDo;
r.run();
return null;
}
}.call();
}
public void message(String s) {
message = s;
}
public static void main(String[] args) throws Exception {
new ProtectedInaccessibleMethodRefTest().doTest();
if (!message.equals("OK!"))
throw new AssertionError("Unexpected output");
if (!sMessage.equals("OK!"))
throw new AssertionError("Unexpected output");
}
}

40
langtools/test/tools/javac/lambda/methodReference/pack/SuperClass.java Normal file
View file

@ -0,0 +1,40 @@
/*
* Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package pack;
public class SuperClass {
public static String sMessage = "Not OK";
protected final void myDo() {
message("OK!");
}
protected static final void myStaticDo() {
sMessage = "OK!";
}
public void message(String s) {
}
}