8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)

Reviewed-by: lancea, bchristi
This commit is contained in:
Jaikiran Pai 2020-09-16 15:10:57 +00:00 committed by Lance Andersen
parent 10867134fd
commit e5866aa756
2 changed files with 79 additions and 2 deletions

View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 1996, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1996, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -52,6 +52,9 @@ public class GZIPOutputStream extends DeflaterOutputStream {
*/
private static final int TRAILER_SIZE = 8;
// Represents the default "unknown" value for OS header, per RFC-1952
private static final byte OS_UNKNOWN = (byte) 255;
/**
* Creates a new output stream with the specified buffer size.
*
@ -189,7 +192,7 @@ public class GZIPOutputStream extends DeflaterOutputStream {
0, // Modification time MTIME (int)
0, // Modification time MTIME (int)
0, // Extra flags (XFLG)
0 // Operating system (OS)
OS_UNKNOWN // Operating system (OS)
});
}