archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8241952: (fs) FileChannel.write(ByteBuffer src, long position) does not check for the FileChannel being closed first

Browse source 
Reviewed-by: lancea, alanb
This commit is contained in:
Brian Burkhalter 2020-04-13 10:17:03 -07:00
parent 447d6499f1
commit ea36a53b75
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java
View file

@ -240,8 +240,7 @@ public class FileChannelImpl
public long read(ByteBuffer[] dsts, int offset, int length)
throws IOException
{
if ((offset < 0) || (length < 0) || (offset > dsts.length - length))
throw new IndexOutOfBoundsException();
Objects.checkFromIndexSize(offset, length, dsts.length);
ensureOpen();
if (!readable)
throw new NonReadableChannelException();
@ -297,8 +296,7 @@ public class FileChannelImpl
public long write(ByteBuffer[] srcs, int offset, int length)
throws IOException
{
if ((offset < 0) || (length < 0) || (offset > srcs.length - length))
throw new IndexOutOfBoundsException();
Objects.checkFromIndexSize(offset, length, srcs.length);
ensureOpen();
if (!writable)
throw new NonWritableChannelException();
@ -789,11 +787,11 @@ public class FileChannelImpl
throw new NullPointerException();
if (position < 0)
throw new IllegalArgumentException("Negative position");
ensureOpen();
if (!readable)
throw new NonReadableChannelException();
if (direct)
Util.checkChannelPositionAligned(position, alignment);
ensureOpen();
if (nd.needsPositionLock()) {
synchronized (positionLock) {
return readInternal(dst, position);
@ -829,11 +827,11 @@ public class FileChannelImpl
throw new NullPointerException();
if (position < 0)
throw new IllegalArgumentException("Negative position");
ensureOpen();
if (!writable)
throw new NonWritableChannelException();
if (direct)
Util.checkChannelPositionAligned(position, alignment);
ensureOpen();
if (nd.needsPositionLock()) {
synchronized (positionLock) {
return writeInternal(src, position);