archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-21 19:44:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8068839: newDuration(x) produces incorrect outputs for some values of x

Browse source 
Reviewed-by: rriggs, lancea
This commit is contained in:
Joe Wang 2015-12-11 12:01:26 -08:00
parent 7e3889ef43
commit ea676129ea
2 changed files with 51 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
jaxp/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationImpl.java
View file

@ -357,7 +357,7 @@ class DurationImpl
* The length of the duration in milliseconds.
*/
protected DurationImpl(final long durationInMilliSeconds) {
boolean is0x8000000000000000L = false;
long l = durationInMilliSeconds;
if (l > 0) {
@ -368,6 +368,7 @@ class DurationImpl
if (l == 0x8000000000000000L) {
// negating 0x8000000000000000L causes an overflow
l++;
is0x8000000000000000L = true;
}
l *= -1;
}
@ -406,7 +407,8 @@ class DurationImpl
// seconds & milliseconds
int2long = (gregorianCalendar.get(Calendar.SECOND) * 1000)
+ gregorianCalendar.get(Calendar.MILLISECOND);
+ gregorianCalendar.get(Calendar.MILLISECOND)
+ (is0x8000000000000000L ? 1 : 0);
this.seconds = BigDecimal.valueOf(int2long, 3);
}