archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-09-20 02:54:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException

Browse source 
Reviewed-by: chegar, dfuchs
This commit is contained in:
Michael McMahon 2019-06-24 15:10:44 +01:00
parent 052e0e91c3
commit eccfec498d
1 changed files with 37 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

47
test/jdk/java/net/MulticastSocket/Promiscuous.java
View file

@ -22,7 +22,7 @@
* *
/* @test /* @test
* @bug 8014499 * @bug 8014499 8219804
* @library /test/lib * @library /test/lib
* @summary Test for interference when two sockets are bound to the same * @summary Test for interference when two sockets are bound to the same
* port but joined to different multicast groups * port but joined to different multicast groups
@ -44,11 +44,20 @@ public class Promiscuous {
throws IOException throws IOException
{ {
byte[] ba = new byte[100]; byte[] ba = new byte[100];
DatagramPacket p = new DatagramPacket(ba, ba.length); DatagramPacket p;
try { try {
String data = null;
while (true) {
p = new DatagramPacket(ba, ba.length);
mc.receive(p); mc.receive(p);
int recvId = Integer.parseInt( data = new String(p.getData(), 0, p.getLength(), "UTF-8");
new String(p.getData(), 0, p.getLength(), "UTF-8")); if (data.length() > UUID.length() && data.startsWith(UUID)) {
data = data.substring(UUID.length());
break;
}
logUnexpected(p);
}
int recvId = Integer.parseInt(data);
if (datagramExpected) { if (datagramExpected) {
if (recvId != id) if (recvId != id)
throw new RuntimeException("Unexpected id, got " + recvId throw new RuntimeException("Unexpected id, got " + recvId
@ -67,19 +76,36 @@ public class Promiscuous {
} }
} }
static void logUnexpected(DatagramPacket p) {
byte[] ba = p.getData();
System.out.printf("Unexpected packet: length: %d. First three bytes: %d, %d, %d\n",
p.getLength(), ba[0], ba[1], ba[2]);
}
static final String UUID; // process-id : currentTimeMillis
static {
String s1 = Long.toString(ProcessHandle.current().pid());
String s2 = Long.toString(System.currentTimeMillis());
UUID = "<" + s1 + s2 + ">";
}
static void test(InetAddress group1, InetAddress group2) static void test(InetAddress group1, InetAddress group2)
throws IOException throws IOException
{ {
try (MulticastSocket mc1 = new MulticastSocket(); InetSocketAddress ad1 = new InetSocketAddress(group1, 0);
MulticastSocket mc2 = new MulticastSocket(mc1.getLocalPort()); try (MulticastSocket mc1 = new MulticastSocket(ad1);
MulticastSocket mc2 = new MulticastSocket(
new InetSocketAddress(group2, mc1.getLocalPort()));
DatagramSocket ds = new DatagramSocket()) { DatagramSocket ds = new DatagramSocket()) {
final int port = mc1.getLocalPort(); final int port = mc1.getLocalPort();
out.printf("Using port: %d\n", port); out.printf("Using port: %d\n", port);
mc1.setSoTimeout(TIMEOUT); mc1.setSoTimeout(TIMEOUT);
mc2.setSoTimeout(TIMEOUT); mc2.setSoTimeout(TIMEOUT);
int nextId = id; int nextId = id;
byte[] msg = Integer.toString(nextId).getBytes("UTF-8"); byte[] msg = (UUID + Integer.toString(nextId)).getBytes("UTF-8");
DatagramPacket p = new DatagramPacket(msg, msg.length); DatagramPacket p = new DatagramPacket(msg, msg.length);
p.setAddress(group1); p.setAddress(group1);
p.setPort(port); p.setPort(port);
@ -97,7 +123,7 @@ public class Promiscuous {
receive(mc2, false, 0); receive(mc2, false, 0);
nextId = ++id; nextId = ++id;
msg = Integer.toString(nextId).getBytes("UTF-8"); msg = (UUID + Integer.toString(nextId)).getBytes("UTF-8");
p = new DatagramPacket(msg, msg.length); p = new DatagramPacket(msg, msg.length);
p.setAddress(group2); p.setAddress(group2);
p.setPort(port); p.setPort(port);
@ -116,7 +142,6 @@ public class Promiscuous {
public static void main(String args[]) throws IOException { public static void main(String args[]) throws IOException {
IPSupport.throwSkippedExceptionIfNonOperational(); IPSupport.throwSkippedExceptionIfNonOperational();
String os = System.getProperty("os.name"); String os = System.getProperty("os.name");
// Requires IP_MULTICAST_ALL on Linux (new since 2.6.31) so skip // Requires IP_MULTICAST_ALL on Linux (new since 2.6.31) so skip
@ -133,8 +158,8 @@ public class Promiscuous {
} }
// multicast groups used for the test // multicast groups used for the test
InetAddress ip4Group1 = InetAddress.getByName("224.7.8.9"); InetAddress ip4Group1 = InetAddress.getByName("224.0.0.120");
InetAddress ip4Group2 = InetAddress.getByName("225.4.5.6"); InetAddress ip4Group2 = InetAddress.getByName("224.0.0.121");
test(ip4Group1, ip4Group2); test(ip4Group1, ip4Group2);
} }