archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8280404: Unexpected exception thrown when CEN file entry comment length is not valid

Browse source 
Reviewed-by: alanb
This commit is contained in:
Lance Andersen 2022-03-07 16:10:31 +00:00
parent 8e70f4c3dc
commit f0995abe62
2 changed files with 355 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/java.base/share/classes/java/util/zip/ZipFile.java
View file

@ -1206,8 +1206,17 @@ public class ZipFile implements ZipConstants, Closeable {
entries[index++] = hash;
entries[index++] = next;
entries[index ] = pos;
// Validate comment if it exists
// if the bytes representing the comment cannot be converted to
// a String via zcp.toString, an Exception will be thrown
int clen = CENCOM(cen, pos);
if (clen > 0) {
int elen = CENEXT(cen, pos);
int start = entryPos + nlen + elen;
zcp.toString(cen, start, clen);
}
} catch (Exception e) {
zerror("invalid CEN header (bad entry name)");
zerror("invalid CEN header (bad entry name or comment)");
}
return nlen;
}