archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 14:54:52 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8146298: (dc spec) connect and disconnect methods should specify that they may block

Browse source 
Reviewed-by: alanb, chegar, dfuchs, darcy
This commit is contained in:
Brian Burkhalter 2019-11-14 09:06:43 -08:00
parent 4110efa386
commit f2e8dc42e2
1 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/java.base/share/classes/java/nio/channels/DatagramChannel.java
View file

@ -255,8 +255,11 @@ public abstract class DatagramChannel
* <p> The channel's socket is configured so that it only receives * <p> The channel's socket is configured so that it only receives
* datagrams from, and sends datagrams to, the given remote <i>peer</i> * datagrams from, and sends datagrams to, the given remote <i>peer</i>
* address. Once connected, datagrams may not be received from or sent to * address. Once connected, datagrams may not be received from or sent to
* any other address. A datagram socket remains connected until it is * any other address. Datagrams in the channel's {@linkplain
* explicitly disconnected or until it is closed. * java.net.StandardSocketOptions#SO_RCVBUF socket receive buffer}, which
* have not been {@linkplain #receive(ByteBuffer) received} before invoking
* this method, may be discarded. The channel's socket remains connected
* until it is explicitly disconnected or until it is closed.
* *
* <p> This method performs exactly the same security checks as the {@link * <p> This method performs exactly the same security checks as the {@link
* java.net.DatagramSocket#connect connect} method of the {@link * java.net.DatagramSocket#connect connect} method of the {@link
@ -270,12 +273,13 @@ public abstract class DatagramChannel
* should be taken to ensure that a connected datagram channel is not shared * should be taken to ensure that a connected datagram channel is not shared
* with untrusted code. * with untrusted code.
* *
* <p> This method may be invoked at any time. It will not have any effect * <p> This method may be invoked at any time. If another thread has
* on read or write operations that are already in progress at the moment * already initiated a read or write operation upon this channel, then an
* that it is invoked. If this channel's socket is not bound then this method * invocation of this method will block until any such operation is
* will first cause the socket to be bound to an address that is assigned * complete. If this channel's socket is not bound then this method will
* first cause the socket to be bound to an address that is assigned
* automatically, as if invoking the {@link #bind bind} method with a * automatically, as if invoking the {@link #bind bind} method with a
* parameter of {@code null}. </p> * parameter of {@code null}. </p>
* *
* @param remote * @param remote
* The remote address to which this channel is to be connected * The remote address to which this channel is to be connected
@ -323,9 +327,10 @@ public abstract class DatagramChannel
* from, and sends datagrams to, any remote address so long as the security * from, and sends datagrams to, any remote address so long as the security
* manager, if installed, permits it. * manager, if installed, permits it.
* *
* <p> This method may be invoked at any time. It will not have any effect * <p> This method may be invoked at any time. If another thread has
* on read or write operations that are already in progress at the moment * already initiated a read or write operation upon this channel, then an
* that it is invoked. * invocation of this method will block until any such operation is
* complete.
* *
* <p> If this channel's socket is not connected, or if the channel is * <p> If this channel's socket is not connected, or if the channel is
* closed, then invoking this method has no effect. </p> * closed, then invoking this method has no effect. </p>