archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 23:04:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code

Browse source 
Reviewed-by: mullan
This commit is contained in:
Sergey Tsypanov 2020-09-18 21:26:59 +00:00 • committed by Weijun Wang
parent d35b117956
commit f55dd9d40e
8 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/java.base/share/classes/sun/security/ssl/DTLSOutputRecord.java
View file

@ -36,7 +36,7 @@ import sun.security.ssl.SSLCipher.SSLWriteCipher;
*/
final class DTLSOutputRecord extends OutputRecord implements DTLSRecord {
private DTLSFragmenter fragmenter = null;
private DTLSFragmenter fragmenter;
int writeEpoch;
@ -44,7 +44,7 @@ final class DTLSOutputRecord extends OutputRecord implements DTLSRecord {
Authenticator prevWriteAuthenticator;
SSLWriteCipher prevWriteCipher;
private volatile boolean isCloseWaiting = false;
private volatile boolean isCloseWaiting;
DTLSOutputRecord(HandshakeHash handshakeHash) {
super(handshakeHash, SSLWriteCipher.nullDTlsWriteCipher());

6
src/java.base/share/classes/sun/security/ssl/HandshakeContext.java
View file

@ -102,11 +102,11 @@ abstract class HandshakeContext implements ConnectionContext {
boolean isResumption;
SSLSessionImpl resumingSession;
// Session is using stateless resumption
boolean statelessResumption = false;
boolean statelessResumption;
final Queue<Map.Entry<Byte, ByteBuffer>> delegatedActions;
volatile boolean taskDelegated = false;
volatile Exception delegatedThrown = null;
volatile boolean taskDelegated;
volatile Exception delegatedThrown;
ProtocolVersion negotiatedProtocol;
CipherSuite negotiatedCipherSuite;

8
src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java
View file

@ -37,11 +37,11 @@ import sun.security.ssl.SSLCipher.SSLWriteCipher;
*/
final class SSLEngineOutputRecord extends OutputRecord implements SSLRecord {
private HandshakeFragment fragmenter = null;
private boolean isTalkingToV2 = false; // SSLv2Hello
private ByteBuffer v2ClientHello = null; // SSLv2Hello
private HandshakeFragment fragmenter;
private boolean isTalkingToV2; // SSLv2Hello
private ByteBuffer v2ClientHello; // SSLv2Hello
private volatile boolean isCloseWaiting = false;
private volatile boolean isCloseWaiting;
SSLEngineOutputRecord(HandshakeHash handshakeHash) {
super(handshakeHash, SSLWriteCipher.nullTlsWriteCipher());

4
src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java
View file

@ -83,8 +83,8 @@ public final class SSLSocketImpl
private String peerHost;
private boolean autoClose;
private boolean isConnected = false;
private volatile boolean tlsIsClosed = false;
private boolean isConnected;
private volatile boolean tlsIsClosed;
private final ReentrantLock socketLock = new ReentrantLock();
private final ReentrantLock handshakeLock = new ReentrantLock();