archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-27 23:04:50 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8129855: "-XX:+IgnoreUnrecognizedVMOptions" hides out of range VM options

Browse source 
Implement strict spec rgarding how IgnoreUnrecognizedVMOptions works, supplied with the corresponding test case.

Reviewed-by: dcubed, ddmitriev
This commit is contained in:
Gerard Ziemski 2015-10-23 11:17:23 -05:00
parent 5b0f38dab7
commit f84561609b
5 changed files with 209 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

14
hotspot/src/share/vm/runtime/arguments.cpp
View file

@ -1120,7 +1120,7 @@ bool Arguments::process_argument(const char* arg,
Flag::Flags origin) {
JDK_Version since = JDK_Version();
if (parse_argument(arg, origin) || ignore_unrecognized) {
if (parse_argument(arg, origin)) {
return true;
}
@ -1156,7 +1156,7 @@ bool Arguments::process_argument(const char* arg,
Flag* found_flag = Flag::find_flag((const char*)argname, arg_len, true, true);
if (found_flag != NULL) {
char locked_message_buf[BUFLEN];
found_flag->get_locked_message(locked_message_buf, BUFLEN);
Flag::MsgType msg_type = found_flag->get_locked_message(locked_message_buf, BUFLEN);
if (strlen(locked_message_buf) == 0) {
if (found_flag->is_bool() && !has_plus_minus) {
jio_fprintf(defaultStream::error_stream(),
@ -1169,9 +1169,19 @@ bool Arguments::process_argument(const char* arg,
"Improperly specified VM option '%s'\n", argname);
}
} else {
#ifdef PRODUCT
bool mismatched = ((msg_type == Flag::NOTPRODUCT_FLAG_BUT_PRODUCT_BUILD) ||
(msg_type == Flag::DEVELOPER_FLAG_BUT_PRODUCT_BUILD));
if (ignore_unrecognized && mismatched) {
return true;
}
#endif
jio_fprintf(defaultStream::error_stream(), "%s", locked_message_buf);
}
} else {
if (ignore_unrecognized) {
return true;
}
jio_fprintf(defaultStream::error_stream(),
"Unrecognized VM option '%s'\n", argname);
Flag* fuzzy_matched = Flag::fuzzy_match((const char*)argname, arg_len, true);