archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-26 22:34:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8325189: Enable this-escape javac warning in java.base

Browse source 
Reviewed-by: alanb, erikj, naoto, smarks, ihse, joehw, lancea, weijun
This commit is contained in:
Joe Darcy 2024-02-07 20:05:11 +00:00
parent 299a8ee68d
commit fbd15b2087
93 changed files with 151 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/java.base/share/classes/java/net/ServerSocket.java
View file

@ -266,6 +266,7 @@ public class ServerSocket implements java.io.Closeable {
* @see SecurityManager#checkListen
* @since 1.1
*/
@SuppressWarnings("this-escape")
public ServerSocket(int port, int backlog, InetAddress bindAddr) throws IOException {
if (port < 0 || port > 0xFFFF)
throw new IllegalArgumentException("Port value out of range: " + port);

7
src/java.base/share/classes/java/net/Socket.java
View file

@ -211,6 +211,7 @@ public class Socket implements java.io.Closeable {
*
* @since 1.5
*/
@SuppressWarnings("this-escape")
public Socket(Proxy proxy) {
// Create a copy of Proxy as a security measure
if (proxy == null) {
@ -319,6 +320,7 @@ public class Socket implements java.io.Closeable {
* @see java.net.SocketImpl
* @see SecurityManager#checkConnect
*/
@SuppressWarnings("this-escape")
public Socket(String host, int port)
throws UnknownHostException, IOException
{
@ -353,6 +355,7 @@ public class Socket implements java.io.Closeable {
* @see java.net.SocketImpl
* @see SecurityManager#checkConnect
*/
@SuppressWarnings("this-escape")
public Socket(InetAddress address, int port) throws IOException {
this(address != null ? new InetSocketAddress(address, port) : null,
(SocketAddress) null, true);
@ -394,6 +397,7 @@ public class Socket implements java.io.Closeable {
* @see SecurityManager#checkConnect
* @since 1.1
*/
@SuppressWarnings("this-escape")
public Socket(String host, int port, InetAddress localAddr,
int localPort) throws IOException {
this(host != null ? new InetSocketAddress(host, port) :
@ -436,6 +440,7 @@ public class Socket implements java.io.Closeable {
* @see SecurityManager#checkConnect
* @since 1.1
*/
@SuppressWarnings("this-escape")
public Socket(InetAddress address, int port, InetAddress localAddr,
int localPort) throws IOException {
this(address != null ? new InetSocketAddress(address, port) : null,
@ -483,6 +488,7 @@ public class Socket implements java.io.Closeable {
* @deprecated Use DatagramSocket instead for UDP transport.
*/
@Deprecated
@SuppressWarnings("this-escape")
public Socket(String host, int port, boolean stream) throws IOException {
this(host != null ? new InetSocketAddress(host, port) :
new InetSocketAddress(InetAddress.getByName(null), port),
@ -525,6 +531,7 @@ public class Socket implements java.io.Closeable {
* @deprecated Use DatagramSocket instead for UDP transport.
*/
@Deprecated
@SuppressWarnings("this-escape")
public Socket(InetAddress host, int port, boolean stream) throws IOException {
this(host != null ? new InetSocketAddress(host, port) : null,
new InetSocketAddress(0), stream);