archive/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2025-08-26 22:34:27 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system

Browse source 
Reviewed-by: lancea, alanb
This commit is contained in:
Brian Burkhalter 2022-03-10 17:36:51 +00:00
parent e8a1ce00b2
commit fdce97df5f
5 changed files with 54 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

48
src/java.base/share/classes/java/nio/file/CopyMoveHelper.java
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -105,11 +105,20 @@ class CopyMoveHelper {
LinkOption[] linkOptions = (opts.followLinks) ? new LinkOption[0] :
new LinkOption[] { LinkOption.NOFOLLOW_LINKS };
// retrieve source posix view, null if unsupported
final PosixFileAttributeView sourcePosixView =
Files.getFileAttributeView(source, PosixFileAttributeView.class);
// attributes of source file
BasicFileAttributes attrs = Files.readAttributes(source,
BasicFileAttributes.class,
linkOptions);
if (attrs.isSymbolicLink())
BasicFileAttributes sourceAttrs = sourcePosixView != null ?
Files.readAttributes(source,
PosixFileAttributes.class,
linkOptions) :
Files.readAttributes(source,
BasicFileAttributes.class,
linkOptions);
if (sourceAttrs.isSymbolicLink())
throw new IOException("Copying of symbolic links not supported");
// delete target if it exists and REPLACE_EXISTING is specified
@ -119,7 +128,7 @@ class CopyMoveHelper {
throw new FileAlreadyExistsException(target.toString());
// create directory or copy file
if (attrs.isDirectory()) {
if (sourceAttrs.isDirectory()) {
Files.createDirectory(target);
} else {
try (InputStream in = Files.newInputStream(source)) {
@ -127,14 +136,29 @@ class CopyMoveHelper {
}
}
// copy basic attributes to target
// copy basic and, if supported, POSIX attributes to target
if (opts.copyAttributes) {
BasicFileAttributeView view =
Files.getFileAttributeView(target, BasicFileAttributeView.class);
BasicFileAttributeView targetView = null;
if (sourcePosixView != null) {
targetView = Files.getFileAttributeView(target,
PosixFileAttributeView.class);
}
// target might not support posix even if source does
if (targetView == null) {
targetView = Files.getFileAttributeView(target,
BasicFileAttributeView.class);
}
try {
view.setTimes(attrs.lastModifiedTime(),
attrs.lastAccessTime(),
attrs.creationTime());
targetView.setTimes(sourceAttrs.lastModifiedTime(),
sourceAttrs.lastAccessTime(),
sourceAttrs.creationTime());
if (sourceAttrs instanceof PosixFileAttributes sourcePosixAttrs &&
targetView instanceof PosixFileAttributeView targetPosixView) {
targetPosixView.setPermissions(sourcePosixAttrs.permissions());
}
} catch (Throwable x) {
// rollback
try {