Commit graph

64 commits

Author SHA1 Message Date
Kevin Driver
550e5d7822 4958071: (spec) confusing exception list for javax.crypto.Cipher.init(...) for
Reviewed-by: valeriep, wetmore
2022-08-30 18:23:46 +00:00
Bradford Wetmore
791fc5791a 6383195: javax.crypto.spec.PBEKeySpec is not thread safe
Reviewed-by: weijun
2022-07-28 22:04:44 +00:00
Mark Powers
f804f2ce8e 8284851: Update javax.crypto files to use proper javadoc for mentioned classes
Reviewed-by: weijun, valeriep
2022-07-07 23:20:58 +00:00
Hai-May Chao
8f400b9aab 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true'
Reviewed-by: mullan, rhalade
2022-06-13 15:31:58 +00:00
Valerie Peng
0c5ab6daa9 8209038: Clarify the javadoc of Cipher.getParameters()
Reviewed-by: xuelei, mullan, weijun
2022-05-17 18:37:23 +00:00
Roger Riggs
17c52789b7 8286378: Address possibly lossy conversions in java.base
Reviewed-by: naoto, xuelei, bpb, alanb
2022-05-12 16:50:36 +00:00
Valerie Peng
15ce8c6195 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec
Reviewed-by: mullan
2022-04-20 17:23:06 +00:00
Anthony Scarpino
f61d121124 8281388: Change wrapping of EncryptedPrivateKeyInfo
Reviewed-by: jnimeh
2022-04-19 22:18:33 +00:00
Magnus Ihse Bursie
fb469fb894 8284893: Fix typos in java.base
Reviewed-by: iris, wetmore, lancea, mullan, naoto
2022-04-19 20:07:57 +00:00
Mark Powers
41fc078323 8284112: Minor cleanup could be done in javax.crypto
Reviewed-by: wetmore
2022-04-18 23:48:22 +00:00
Andrey Turbanov
8e58d4a589 8284415: Collapse identical catch branches in security libs
Reviewed-by: coffeys, xuelei, wetmore
2022-04-07 10:00:08 +00:00
Luis Pinto
63fec5da27 8283525: http://tools.ietf.org/html/* URLs return 404
Reviewed-by: coffeys
2022-04-01 13:26:20 +00:00
Andrey Turbanov
dc5a65ab37 8283426: Fix 'exeption' typo
Reviewed-by: xuelei, iris, dholmes, wetmore, aivanov
2022-03-24 19:52:16 +00:00
Jesper Wilhelmsson
4616c13c2f Merge 2022-01-20 01:18:38 +00:00
Anthony Scarpino
6b6f829b46 8269151: Better construction of EncryptedPrivateKeyInfo
Reviewed-by: jnimeh, mschoene, rhalade
2022-01-18 23:35:34 +00:00
Andrey Turbanov
dee447f8ae 8274809: Update java.base classes to use try-with-resources
Reviewed-by: mullan, alanb, dfuchs
2022-01-10 16:20:58 +00:00
Andrey Turbanov
debaa28e9c 8274679: Remove unnecessary conversion to String in security code in java.base
Reviewed-by: weijun
2022-01-10 15:02:57 +00:00
Daniel Jelinski
f31dead6c5 8279043: Some Security Exception Messages Miss Spaces
Reviewed-by: weijun
2021-12-21 18:24:31 +00:00
Valerie Peng
470e8a0fda 8266103: Better specified spec values
Reviewed-by: mullan, rhalade, mschoene
2021-10-19 18:25:59 +00:00
Andrey Turbanov
79cebe2c1b 8274050: Unnecessary Vector usage in javax.crypto
Reviewed-by: valeriep
2021-09-29 18:22:40 +00:00
Bradford Wetmore
c8af8238b4 8267485: Remove the dependency on SecurityManager in JceSecurityManager.java
Reviewed-by: mchung
2021-07-27 17:11:13 +00:00
Weijun Wang
40d23a0c0b 8267543: Post JEP 411 refactoring: security
Reviewed-by: mullan
2021-06-02 15:47:57 +00:00
Weijun Wang
6765f90250 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
Co-authored-by: Sean Mullan <mullan@openjdk.org>
Co-authored-by: Lance Andersen <lancea@openjdk.org>
Co-authored-by: Weijun Wang <weijun@openjdk.org>
Reviewed-by: erikj, darcy, chegar, naoto, joehw, alanb, mchung, kcr, prr, lancea
2021-06-02 11:57:31 +00:00
Weijun Wang
f834557ae0 8258915: Temporary buffer cleanup
Reviewed-by: valeriep
2021-04-22 18:11:43 +00:00
Valerie Peng
434a399bea 8260274: Cipher.init(int, key) does not use highest priority provider for random bytes
Reviewed-by: ascarpino, xuelei
2021-03-18 23:23:19 +00:00
Sergey Tsypanov
c0176c42dc 8263552: Use String.valueOf() for char-to-String conversions
Reviewed-by: redestad, vtewari, azvegint, chegar
2021-03-15 11:18:59 +00:00
Bradford Wetmore
32cbd193d9 8263105: security-libs doclint cleanup
Reviewed-by: iris, darcy, dfuchs, mullan
2021-03-11 00:26:26 +00:00
Jonathan Gibbons
718298506d 8263104: fix warnings for empty paragraphs
Reviewed-by: alanb, lancea
2021-03-06 15:06:49 +00:00
Jamil Nimeh
6b6f794051 8248223: KeyAgreement spec update on multi-party key exchange support
Reviewed-by: mullan
2021-02-16 17:40:29 +00:00
Valerie Peng
03f2ab325d 8246383: NullPointerException in JceSecurity.getVerificationResult when using Entrust provider
Removed the static SecureRandom object in JceSecurity whose instantion caused NPE

Reviewed-by: xuelei
2020-08-21 03:09:42 +00:00
Joe Darcy
5db58348f8 8250246: Address reliance on default constructors in security libs
Reviewed-by: mullan
2020-07-24 13:49:38 -07:00
Valerie Peng
b94314a0d9 8087327: CipherStream produces new byte array on every update or doFinal operation
Changed Cipher[In/Out]putStream to allocate a buffer and reuse it

Reviewed-by: weijun
2020-06-04 20:30:16 +00:00
Weijun Wang
bcbe46b0b3 8246397: Use KnownOIDs for known OIDs
Reviewed-by: xuelei
2020-06-04 10:04:32 +08:00
Ivan Gerasimov
3790e58090 8241761: Typos: empty lines in javadoc, inconsistent indents, etc. (security-libs only)
Reviewed-by: weijun
2020-04-01 18:38:05 -07:00
Pavel Rappo
17ff85d4ad 8241014: Miscellaneous typos in documentation comments
Reviewed-by: igerasim, prappo, psandoz, rriggs, weijun
2020-03-20 20:54:56 +00:00
Valerie Peng
d4c0619b3b 8233016: javax.crypto.Cipher throws NPE for the given custom CipherSpi and Provider
Changed to throw IAE instead of NPE for non-null invalid arguments

Reviewed-by: mullan
2019-12-05 03:55:52 +00:00
Sean Mullan
b171594072 8214483: Remove algorithms that use MD5 or DES from security requirements
Reviewed-by: xuelei
2019-11-13 13:43:06 -05:00
Ivan Gerasimov
8e859259bc 8233884: Avoid looking up standard charsets in security libraries
Reviewed-by: coffeys
2019-11-12 01:36:17 -08:00
Joe Darcy
fbb4093562 8231262: Suppress warnings on non-serializable instance fields in security libs serializable classes
Reviewed-by: mullan, chegar
2019-10-09 09:57:41 -07:00
Joe Darcy
6d4ef5aaf3 8229999: Apply java.io.Serial annotations to security types in java.base
Reviewed-by: rriggs, mullan
2019-08-29 10:52:21 -07:00
Valerie Peng
6b662abe74 8180392: SunJCE provider should throw exceptions for unsupported mode and padding combinations
Change JCA Cipher class to create obj to ensure the mode and padding combination is supported

Reviewed-by: xuelei
2019-07-25 02:16:49 +00:00
Valerie Peng
29215b987b 8181386: CipherSpi ByteBuffer to byte array conversion fails for certain data overlap conditions
Detect potential buffer overlap and use extra buffer if necessary

Reviewed-by: xuelei
2019-07-10 18:43:45 +00:00
Valerie Peng
74d45e481d 7107615: scalability bloker in javax.crypto.JceSecurity
Change to use ConcurrentHashMap instead of syncing on whole method

Reviewed-by: xuelei, alanb, dfuchs
2019-05-22 21:38:16 +00:00
Henry Jen
def1ac3acc Merge 2018-12-13 11:51:06 -08:00
Claes Redestad
a3df1d618e 8215281: Use String.isEmpty() when applicable in java.base
Reviewed-by: dfuchs, alanb
2018-12-13 15:31:05 +01:00
Roger Riggs
938b844088 8214971: Replace use of string.equals("") with isEmpty()
Reviewed-by: jlaskey, prappo, lancea, dfuchs, redestad
2018-12-07 11:51:17 -05:00
Valerie Peng
f094ffdbae 8203654: Improve cypher state updates
Reviewed-by: ascarpino
2018-06-14 23:47:05 +00:00
Sean Coffey
63b433923c 8210838: Override javax.crypto.Cipher.toString()
Reviewed-by: mullan, weijun
2018-11-19 09:56:42 +00:00
Mandy Chung
9ffe7e1205 8211122: Reduce the number of internal classes made accessible to jdk.unsupported
Reviewed-by: alanb, dfuchs, kvn
2018-11-06 10:01:16 -08:00
Sean Mullan
30745fe1a8 8212669: Add note to Cipher javadoc about using full transformation and not relying on defaults
Reviewed-by: xuelei
2018-11-01 16:53:54 -04:00