archive/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2025-08-15 14:11:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

lib: 842: Improve error handling in sw842_compress()

Browse source 
The static code analysis tool "Coverity Scan" pointed the following
implementation details out for further development considerations:
CID 1309755: Unused value
In sw842_compress: A value assigned to a variable is never used. (CWE-563)
returned_value: Assigning value from add_repeat_template(p, repeat_count)
to ret here, but that stored value is overwritten before it can be used.

Conclusion:
Add error handling for the return value from an add_repeat_template()
call.

Fixes: 2da572c959 ("lib: add software 842 compression/decompression")
Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Tanya Agarwal 2025-01-14 19:42:04 +05:30 • committed by Herbert Xu
parent 9739f5f93b
commit af324dc0e2
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/842/842_compress.c
View file

@ -532,6 +532,8 @@ int sw842_compress(const u8 *in, unsigned int ilen,
} }
if (repeat_count) { if (repeat_count) {
ret = add_repeat_template(p, repeat_count); ret = add_repeat_template(p, repeat_count);
if (ret)
return ret;
repeat_count = 0; repeat_count = 0;
if (next == last) /* reached max repeat bits */ if (next == last) /* reached max repeat bits */
goto repeat; goto repeat;